Skip to content

Add test case for GH-13774 #14945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add test case for GH-13774 #14945

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jul 13, 2024

Besides demonstrating the new behavior, this test also ensures that the bundled and external libgd now behave the same. It has to be noted, though, that we only test one of the five code paths.

Besides demonstrating the new behavior, this test also ensures that the
bundled and external libgd now behave the same.  It has to be noted,
though, that we only test one of the five code paths.
@cmb69 cmb69 marked this pull request as ready for review July 14, 2024 09:53
@cmb69 cmb69 requested a review from devnexen as a code owner July 14, 2024 09:53
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@cmb69
Copy link
Member Author

cmb69 commented Jul 14, 2024

Ah, I've inadvertently targeted master; this should go into PHP 8.2 instead. Okay to do so?

@devnexen
Copy link
Member

Ok, make sense for 8.2

@cmb69 cmb69 closed this in 6d0db52 Jul 14, 2024
@cmb69 cmb69 deleted the cmb/gh13774 branch July 14, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants