Disallow indirect modification on readonly properties within __clone() #15012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
force-pushed
the
disallow-indirect-modification-in-readonly-clone
branch
from
ad503d0 to
14be48b
Compare
|
It looks like this reverts the behavior introduced by https://wiki.php.net/rfc/readonly_amendments (that was voted and accepted). I have no idea about the desired behavior, but if something was introduced by mistake, please consider refactoring the whole https://wiki.php.net/rfc/readonly_amendments patch. cc: @kocsismate |
kocsismate
reviewed
Jul 24, 2024
|
Thanks for finding this inconsistency with #7942.
It only reverts some part of it where the property is modified indirectly. |
iluuu1994
force-pushed
the
disallow-indirect-modification-in-readonly-clone
branch
2 times, most recently
from
624c061 to
e6120aa
Compare
iluuu1994
force-pushed
the
disallow-indirect-modification-in-readonly-clone
branch
from
e6120aa to
ba5e67e
Compare
|
I didn't realize this required JIT changes. @dstogov Can you please check if they look correct to you? |
dstogov
approved these changes
Aug 9, 2024
Indirect modification isn't allowed in __construct() because it allows references to leak, so it doesn't make much sense to allow it in __clone().
iluuu1994
force-pushed
the
disallow-indirect-modification-in-readonly-clone
branch
from
ba5e67e to
2cf7993
Compare
|
@dstogov Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indirect modification isn't allowed in __construct() because it allows references to leak, so it doesn't make much sense to allow it in __clone().