Skip to content

Autotools: Quote PHP_ADD_LIB* arguments #15112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jul 26, 2024

Following previous CS syncs, this quotes arguments in PHP_ADD_LIB* M4 macros:

  • PHP_ADD_LIBRARY
  • PHP_ADD_LIBRARY_WITH_PATH
  • PHP_ADD_LIBPATH

Following previous CS syncs, this quotes arguments in PHP_ADD_LIB* M4
macros:
- PHP_ADD_LIBRARY
- PHP_ADD_LIBRARY_WITH_PATH
- PHP_ADD_LIBPATH
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

Copy link
Member

@NattyNarwhal NattyNarwhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok odbc

@petk petk merged commit ff4b99e into php:master Jul 26, 2024
10 of 11 checks passed
@petk petk deleted the patch-PHP_ADD_LIBRARY_WITH_PATH branch July 26, 2024 21:26
devnexen pushed a commit to devnexen/php-src that referenced this pull request Jul 27, 2024
Following previous CS syncs, this quotes arguments in PHP_ADD_LIB* M4
macros:
- PHP_ADD_LIBRARY
- PHP_ADD_LIBRARY_WITH_PATH
- PHP_ADD_LIBPATH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants