ext/standard/info.c: Various refactoring #15366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
filter-refactor
branch
2 times, most recently
from
3cc121c to
55050a1
Compare
|
@cmb69 could you maybe double-check the Windows changes? |
cmb69
reviewed
Aug 13, 2024
There was a problem hiding this comment.
I've left a couple of remarks. The changes to info.c look generally good to me.
It's amazing to see 350 LOC just to get the name of the Windows version. We could drop a few, since we're no longer supporting Vista and 7 and the respective server versions, but that shouldn't be done in this refactoring PR.
Girgias
force-pushed
the
filter-refactor
branch
from
55050a1 to
b0bf00b
Compare
Girgias
changed the title
|
I merged some changes, split the |
cmb69
approved these changes
Aug 13, 2024
| @@ -602,9 +602,10 @@ static char* php_get_windows_name() | |||
| } | |||
| } | |||
| } else { | |||
| return NULL; | |||
| ZEND_UNREACHABLE(); | |||
There was a problem hiding this comment.
Yeah, I think this is fine given that this PR targets master.
Girgias
force-pushed
the
filter-refactor
branch
from
f0d057f to
d980e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.