Deprecate Soft-deprecated DOMDocument and DOMEntity properties

[kocsismate]

RFC: https://wiki.php.net/rfc/deprecations_php_8_4#formally_deprecate_soft-deprecated_domdocument_and_domentity_properties

[Girgias]

Looks reasonable to me, will wait for Niels to confirm.

[Girgias]

Niels has let me know that he's in the USA for a week, so let's merge it before beta1 and if there are issues we can always amend the implementation

[nielsdos]

Just checking this out quickly on my phone. The code seems right, however note that doing var_dump on a dom document will now emit deprecation warnings for the properties as well. Idk if this is desired and/or consistent with other deprecated properties.

[kocsismate]

@nielsdos thanks for checking it even on a phone! I think we should not emit deprecations during var_dumping... I'm wondering though what the best fix would be... but it's a tough question. :/ Maybe adding a bool silent parameter to read functions? This may be the cleanest, but the most pervasive solution I can come up with. Do you have any better suggestion?

[nielsdos]

@kocsismate Adding a bool silent parameter is indeed a possibility. What I don't like about it is that, as you already hinted, we need to modify all handlers for a parameter which won't be used in the majority of cases.

Another possibility is to add a module global variable to silence deprecations. Set it to true in the debug object handler, and reset it to false once that handler finishes. Then just check the global in the relevant read handlers.
This works because the debug object handler won't be re-entered.

[kocsismate]

@nielsdos My original idea was to disable emitting warnings, similarly how warnings can be converted to exceptions, but since I didn't find an existing solution, I gave up the idea.

Besides, my other idea was along the lines of the global-based approach as you mentioned, but I neither liked this, since it required extending global state. However, I guess this is still acceptable, especially that it's a temporary solution for a few years. So if you are also OK, then I'll do the followup soon.

[nielsdos]

Global-based approach is fine for me as it's temporary anyway.

[kocsismate]

filed #15530 to fix the behavior