Skip to content

Fix GH-15613: unpack on format hex strings repeater value. #15615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-15613: unpack on format hex strings repeater value. #15615

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen devnexen force-pushed the gh15613 branch 2 times, most recently from abb778b to a75ee02 Compare August 28, 2024 12:27
@devnexen devnexen marked this pull request as ready for review August 28, 2024 14:02
@devnexen devnexen requested a review from bukka as a code owner August 28, 2024 14:02
@devnexen devnexen requested a review from Girgias August 30, 2024 14:07
@devnexen devnexen linked an issue Sep 5, 2024 that may be closed by this pull request
Signed integer overflow in ext/standard/pack.c #15613
Closed
cmb69
cmb69 reviewed Sep 10, 2024
View reviewed changes
cmb69
cmb69 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

You should probably wait with merging, since 8.3.12RC1 has already been tagged, and it wouldn't make much sense to have the fix in 8.2.24RC1 but not in branches above.

@devnexen
Copy link
Member Author

Thanks for letting me know.

@devnexen devnexen closed this in 791a6ef Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@Girgias Girgias Awaiting requested review from Girgias

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signed integer overflow in ext/standard/pack.c
2 participants
@devnexen @cmb69