Implement request #47317: SoapServer::__getLastResponse() #15792
Conversation
Convenient for debugging.
| @@ -983,6 +983,11 @@ PHP_METHOD(SoapServer, __construct) | |||
| } | |||
| } | |||
|
|
|||
| if ((tmp = zend_hash_find(ht, ZSTR_KNOWN(ZEND_STR_TRACE))) != NULL && | |||
| (Z_TYPE_P(tmp) == IS_TRUE || | |||
| (Z_TYPE_P(tmp) == IS_LONG && Z_LVAL_P(tmp) == 1))) { | |||
There was a problem hiding this comment.
nit: you do not want to treat as string literals eventually ?
There was a problem hiding this comment.
I'm not sure I understand the question.
In any case, this check was copied over from SoapClient so that the behaviour is consistent.
There was a problem hiding this comment.
I meant considering "trace" => "true" but if this is consistent then it s fine :)
There was a problem hiding this comment.
Oh I see. Some people may be tempted to do this, and the annoying thing is that passing wrong types in the options array does not cause an exception, the option just gets ignored in that case... however, instead of allowing "true" I rather start throwing exceptions on wrong options.
|
Asking RM approval to land this in 8.4, @SakiTakamachi @ericmann @NattyNarwhal |
Convenient for debugging.