ext/pgsql: pgsql_copy_from to support iterable. #16124
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -847,7 +847,7 @@ function pg_put_line($connection, string $query = UNKNOWN): bool {} | |||||
| */ | ||||||
| function pg_copy_to(PgSql\Connection $connection, string $table_name, string $separator = "\t", string $null_as = "\\\\N"): array|false {} | ||||||
|
|
||||||
| function pg_copy_from(PgSql\Connection $connection, string $table_name, array|object $rows, string $separator = "\t", string $null_as = "\\\\N"): bool {} | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| /** | ||||||
| * @param PgSql\Connection|string $connection | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| --TEST-- | ||
| pg_copy_from with an iterable | ||
| --EXTENSIONS-- | ||
| pgsql | ||
| --SKIPIF-- | ||
| <?php include("inc/skipif.inc"); ?> | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| include('inc/config.inc'); | ||
| $table_name = "table_copy_iter"; | ||
|
|
||
| $db = pg_connect($conn_str); | ||
| pg_query($db, "CREATE TABLE {$table_name} (num int)"); | ||
|
|
||
| $iter = new class implements Iterator { | ||
| var $count = 0; | ||
| var $values = Array(1,2,3); | ||
|
|
||
| public function next(): void { | ||
| ++$this->count; | ||
| } | ||
|
|
||
| public function rewind(): void { | ||
| $this->count = 0; | ||
| } | ||
|
|
||
| public function current(): int { | ||
| return $this->values[$this->count]; | ||
| } | ||
|
|
||
| public function key(): int { | ||
| return $this->count; | ||
| } | ||
|
|
||
| public function valid(): bool { | ||
| return $this->count < count($this->values); | ||
| } | ||
| }; | ||
|
|
||
| try { | ||
| pg_copy_from($db, $table_name, new stdClass()); | ||
| } catch (\TypeError $e) { | ||
| echo $e->getMessage() . PHP_EOL; | ||
| } | ||
| var_dump(pg_copy_from($db, $table_name, $iter)); | ||
| $res = pg_query($db, "SELECT FROM {$table_name}"); | ||
| var_dump(count(pg_fetch_all($res)) == 3); | ||
|
|
||
| ?> | ||
| --CLEAN-- | ||
| <?php | ||
| include('inc/config.inc'); | ||
| $table_name = "table_copy_iter"; | ||
|
|
||
| $db = pg_connect($conn_str); | ||
| pg_query($db, "DROP TABLE IF EXISTS {$table_name}"); | ||
| ?> | ||
| --EXPECT-- | ||
| pg_copy_from(): Argument #3 ($rows) must be of type Traversable | ||
| bool(true) | ||
| bool(true) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
Z_PARAM_ITERABLE