FFI: support symbol lookup without specifying lib on Windows #16351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works similar to `dlsym(RTLD_DEFAULT, …)` with the caveat that symbols on Windows may not be unique, and are usually qualified by the module they are exported from. That means that wrong symbols may be fetched, potentially causing serious issues; therefore this usage is not recommended for production purposes, but is a nice simplification for quick experiments and the ext/ffi test suite.
dstogov
reviewed
Oct 11, 2024
dstogov
approved these changes
Oct 11, 2024
cmb69
added a commit
that referenced
this pull request
Oct 20, 2024
PR #16351 introduced `EnumProcessModules()` calls, but this function is undefined; thus, the compiler mangles the name according to the default calling convention. This lets linking succeed for x64, but fail for x86. To properly fix this, we include <Psapi.h> where the function is declared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works similar to
dlsym(RTLD_DEFAULT, …)with the caveat that symbols on Windows may not be unique, and are usually qualified by the module they are exported from. That means that wrong symbols may be fetched, potentially causing serious issues; therefore this usage is not recommended for production purposes, but is a nice simplification for quick experiments and the ext/ffi test suite.Note that a particular example for where this shouldn't be used is gh14626.phpt which uses
malloc()which is, contrary to skip reason, available on Windows easily multiple times (I had it in a debug build in ucrtbase.dll, ucrtbased.dll and msvcrt.dll at least).