Skip to content

Drop duplicate macro definitions #16848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Drop duplicate macro definitions #16848

merged 1 commit into from
Nov 25, 2024

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Nov 18, 2024

Apparently, these have been overlooked when the macro definitions have been moved from dns.c to php_dns.h[1].

[1] 6f2f228

Apparently, these have been overlooked when the macro definitions have
been moved from dns.c to php_dns.h[1].

[1] <php@6f2f228>
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@cmb69 cmb69 merged commit 288776e into php:master Nov 25, 2024
10 checks passed
@cmb69 cmb69 deleted the cmb/dns-macros-win branch November 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants