Improve error message when overriding untyped property with typed property #16866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you're misunderstanding the message. The problem is not that it is already defined, but that it is defined differently. The message says the type must be omitted, "as in class X". |
|
I just got this error message while updating a very large code base. The error message didn't quite help me so I am trying to make it easier to understand. Maybe this version is better? |
iluuu1994
reviewed
Nov 19, 2024
Co-authored-by: Ilija Tovilo <[email protected]>
|
thanks for the excellent suggestion! |
|
I only found these tests. |
TimWolla
reviewed
Nov 20, 2024
Zend/tests/type_declarations/mixed/inheritance/mixed_property_inheritance_error7.phpt
Outdated
Show resolved
Hide resolved
TimWolla
changed the title
TimWolla
approved these changes
Nov 20, 2024
|
Thank you @chx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.