Skip to content

Cleanup iterator instantiation code #17358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2025
Merged

Cleanup iterator instantiation code #17358

merged 1 commit into from
Jan 4, 2025

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Jan 4, 2025

Just using object_init_ex() directly makes the code a bit simpler and avoids unnecessary indirections.

@nielsdos
Cleanup iterator instantiation code
c1f95a8 
Just using object_init_ex() directly makes the code a bit simpler and
avoids unnecessary indirections.
Girgias
Girgias approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me

@nielsdos nielsdos merged commit 7be3649 into php:master Jan 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias