Skip to content

Fix stubs of DateTimeZone->getTransitions #17992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

Fix stubs of DateTimeZone->getTransitions #17992

merged 2 commits into from
Jun 4, 2025

Conversation

marc-mabe
Copy link
Contributor

The default value of timestamp_end is INT32_MAX and not ZEND_LONG_MAX.

Additionally, changing the default to ZEND_LONG_MAX would result in an OOM error on calling the function without params.

@marc-mabe marc-mabe requested a review from kocsismate as a code owner March 7, 2025 11:45
@marc-mabe marc-mabe requested a review from derickr as a code owner March 7, 2025 13:33
kocsismate
kocsismate approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derickr
Copy link
Member

derickr commented Mar 28, 2025

Isn't there a similar issue with the start time? Shouldn't that not be -2147483648 instead of PHP_INT_MIN ?

@marc-mabe
Copy link
Contributor Author

marc-mabe commented Mar 28, 2025 •
edited
Loading

@derickr it's defined as zend_long timestamp_begin = ZEND_LONG_MIN, timestamp_end = INT32_MAX; - see https://github.com/php/php-src/blob/php-8.4.5/ext/date/php_date.c#L4317

derickr
derickr approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're right. LGTM, but it looks like you need to rebase first.

marc-mabe and others added 2 commits May 26, 2025 17:45
@marc-mabe
Fix stubs of DateTimeZone->getTransitions
a9700cf 
The default value of `timestamp_end` is INT32_MAX and not ZEND_LONG_MAX
@marc-mabe
Update unrelated tests for param default value using const
cebb4a6
@marc-mabe
Copy link
Contributor Author

Ah, you're right. LGTM, but it looks like you need to rebase first.

done

DanielEScherzer
DanielEScherzer approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI failure was my fault and got fixed by in #18666

@DanielEScherzer DanielEScherzer merged commit 3a14ce1 into php:master Jun 4, 2025
8 of 9 checks passed
@marc-mabe marc-mabe deleted the patch-1 branch June 4, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derickr derickr derickr approved these changes

@kocsismate kocsismate kocsismate approved these changes

@DanielEScherzer DanielEScherzer DanielEScherzer approved these changes

Assignees
No one assigned
Labels
Extension: date Extension: reflection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marc-mabe @derickr @kocsismate @DanielEScherzer