GH-18345: adding Locale::isRightToLeft. #18351
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks is the locale is written left to right. It makes sure all the needed likely subtags are included (maximization) then determines the direction by known matches.
| ZEND_PARSE_PARAMETERS_END(); | ||
|
|
||
| if (!locale_len) { | ||
| locale = (char *)intl_locale_get_default(); |
There was a problem hiding this comment.
How about make the argument nullable and have this behavior when it's null?
There was a problem hiding this comment.
I see, understand.
thanks!
SakiTakamachi
approved these changes
Apr 19, 2025
|
This is a new feature, so I'd like to hear other people's opinions. |
nielsdos
approved these changes
Apr 19, 2025
ext/intl/locale/locale_methods.c
Outdated
| locale = (char *)intl_locale_get_default(); | ||
| } | ||
|
|
||
| RETURN_BOOL(uloc_isRightToLeft((const char *)locale)); |
There was a problem hiding this comment.
Nit: you don't need the cast to const char*, this will happen implicitly
| size_t locale_len; | ||
|
|
||
| ZEND_PARSE_PARAMETERS_START(1, 1) | ||
| Z_PARAM_STRING(locale, locale_len) |
There was a problem hiding this comment.
Nit: Seems like this could be PATH_STRING because NULL bytes are treated as the end of the string.
Although it seems this is not done in this file.
There was a problem hiding this comment.
that s something I planned to revisit separately, the whole bunch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks is the locale is written left to right.
It makes sure all the needed likely subtags are included (maximization) then determines the direction by known matches.