ext/pdo_pgsql: Delete unused constants

[vrana]

These constants were added by 6ed1819 but they are not used anymore.

They are undocumented which is why I've stumbled upon this.

[devnexen]

If that s the case, you need to remove the entries in the related stub too and regenerate using build/gen_stub.php

[devnexen]

Would be good to have a NEWS and above all an UPGRADING entry.

[devnexen]

LCTM @SakiTakamachi please have a look

[SakiTakamachi]

LGTM, thanks.

Just to be sure, I did a GitHub code search, but it seems there is no (public) code that uses these.

[DanielEScherzer]

Is there any harm in keeping them around and deprecating them in 8.5? Just because they are not used on GitHub doesn't mean they aren't used somewhere offline

[vrana]

Like where? Do you have some example?

[devnexen]

Is there any harm in keeping them around and deprecating them in 8.5? Just because they are not used on GitHub doesn't mean they aren't used somewhere offline

You could not know, but it would not make any sense, the driver only cares if the transaction is not idle and the precise state of the said transaction is not even acknowledged from the userland standpoint, only the raw pgsql extension does though.

[devnexen]

gonna merge it @vrana I just forgot your PR

[bukka]

This is API break however so this should not be done no matter if they are used or not. You would need RFC for such change. @devnexen Please revert it.

[bukka]

The only way to drop them is through deprecation RFC

[bukka]

Well it would be probably also possible to create a separate RFC. In any case you cannot just drop constant through PR.

[devnexen]

This is API break however so this should not be done no matter if they are used or not. You would need RFC for such change. @devnexen Please revert it.

done

[DanielEScherzer]

You can add this to https://wiki.php.net/rfc/deprecations_php_8_5