ext/bcmath: use XSSE #18770
Merged
ext/bcmath: use XSSE #18770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
force-pushed
the
bcmath/use_xsse
branch
from
d41bcea to
3e0b363
Compare
nielsdos
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there is no actual issue, the current code may trigger undefined behavior (UB) due to signed integer underflow or overflow on NEON environments. These are essentially just noise.
Since modifying the code to suppress this noise ends up making it identical to XSSE, I’ve decided to incorporate XSSE internally within BCMath.
XSSE already has unit tests implemented using cmocka, and since the APIs being used are of the same kind as before and haven't changed, I’ve determined that using XSSE is safe.
The function names for SIMD will now revert to being compatible with the SSE API, as they were previously.