fix: deleted stray semicolon #18782
Merged
fix: deleted stray semicolon #18782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @NickSdot. Can you please target master? |
Generally, separate PRs are better if the changes are unrelated. |
|
@iluuu1994 done. (i did that intitially with #18781 but the contribution guide says target lowest supported 8?) |
|
@NickSdot Thanks!
This remark only applies to bug fixes, but given this doesn't change behavior and is a dev script, that doesn't really apply. |
|
Thanks @NickSdot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently familiarising myself with the code base. I thought I would just send a patch for findings like this one. Are you all good with that, or are bundled PRs preferred?