Remove curl OpenSSL locking and check for min OpenSSL version #18784
+12
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
changed the title
|
btw. I tested this with different OpenSSL version and doing some tweaks to check if the check works and it seems ok. |
petk
reviewed
Jun 6, 2025
petk
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the curl config check for old libraries to make sure that PHP is not linked with curl that is linked with OpenSSL 1.1.1. This should not normally happen as it usually use the system library and on most installs PHP is installed with OpenSSL that has got already a check for that. However there is a possibility (when PHP is not using OpenSSL and curl is linked against old version), that this could happen so the check is still there just in case. I simplified it a bit though.
It means that it is possible to remove all the locking checks that are no longer needed.