Skip to content

Export php_date_get_interface_ce() for extension use #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jun 28, 2016

@derickr: We spoke about this earlier in mongodb/mongo-php-driver#336 (comment):

Alternatively, do we need to use zend_fetch_class() and resolve the interface name string to a class entry?

That sounds kinda crappy... I'd rather export the interface in PHP (from PHP 7.1).

@Fleshgrinder
Copy link
Contributor

Does this allow userland implementation of the DateTimeInterface? Note that userland classes can never fulfill the contract because they have no way of implementing the operator overloading that both DateTime and DateTimeImmutable provide.

@@ -0,0 +1 @@
../sapi/phpdbg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably shouldn't be part of the patch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how that got in there. Should be removed now, though!

@derickr
Copy link
Member

derickr commented Jun 29, 2016

No, it's just for internal extensions that need to match against either DateTime or DateTimeImmutable.

@jmikola jmikola force-pushed the 7.1-php_date_get_interface_ce branch from b4d230b to 6f1849e Compare June 29, 2016 19:04
@nikic
Copy link
Member

nikic commented Jul 5, 2016

Merged as 7aaa310. Thanks!

@nikic nikic closed this Jul 5, 2016
@jmikola jmikola deleted the 7.1-php_date_get_interface_ce branch July 5, 2016 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants