Fixed getElementsByTagNameNS not filtering on default namespace (bug #67474) #2267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was caused by the fact that dom_get_elements_by_tag_name_ns_raw uses an empty string to filter on the default namespace (as NULL means 'no filter'), whereas in the node itself the default namespace is signalled by nodep->ns being null.
|
Merged a895592 Thanks :) |
php-pulls
pushed a commit
that referenced
this pull request
Jan 2, 2017
php-pulls
pushed a commit
that referenced
this pull request
Jan 2, 2017
* PHP-7.0: news entry for PR #2267 Fixed #67474 (getElementsByTagNameNS and default namespace) Add (failing) testcase for bug #67474
php-pulls
pushed a commit
that referenced
this pull request
Jan 2, 2017
php-pulls
pushed a commit
that referenced
this pull request
Jan 2, 2017
* PHP-7.1: news entry for PR #2267 Fixed #67474 (getElementsByTagNameNS and default namespace) Add (failing) testcase for bug #67474
php-pulls
pushed a commit
that referenced
this pull request
Jan 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was caused by the fact that
dom_get_elements_by_tag_name_ns_rawuses an empty string to filter on the default namespace (as
NULLmeans'no filter'), whereas in the node itself the default namespace is
signalled by
nodep->nsbeingNULL.