Skip to content

Unbundle libzip #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Unbundle libzip #3532

wants to merge 3 commits into from

Conversation

nikic
Copy link
Member

@nikic nikic commented Sep 17, 2018

Since #3531 we're testing on Xenial, which has a sufficiently recent libzip, so we should be able to move ahead with the unbundling.

/cc @remicollet

@KalleZ
Copy link
Member

KalleZ commented Sep 17, 2018

cc @weltling for Windows parts of things as I'm not sure if the buildbot uses the bundled libzip or not

@nikic
Copy link
Member Author

nikic commented Sep 17, 2018

IIRC support for the bundled libzip has already been dropped from the win32 build system in PHP 7.3.

@KalleZ
Copy link
Member

KalleZ commented Sep 17, 2018

@nikic Ah yes, it seems to be the case: 757789e

@nikic
Copy link
Member Author

nikic commented Sep 17, 2018

AppVeyor failure is spurious, so this should be good to go.

@weltling
Copy link
Contributor

External libzip is already in use for 7.2 actually, the bundled one wasn't updated since then. Lower versions don't support encryptiont, even not sure it would compile. Thus, removing the bundled codes is fine.

Thanks.

@nikic
Copy link
Member Author

nikic commented Sep 18, 2018

Aaaand it's gone (c099be4, 4e23dff, 1a55c36).

@nikic nikic closed this Sep 18, 2018
@remicollet
Copy link
Member

@nikic thanks a lot.

php-pulls pushed a commit that referenced this pull request Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants