Extend wildcard files section in editorconfig #4156
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
referenced
this pull request
May 13, 2019
These EOL types are part of different environments and not part of the tests themselves.
nikic
changed the title
Changes: - Trim trailing whitespace for all files except patches. There isn't really any practical reason to not trim the trailing whitespace in all other files. Binary files or phpt files that include trailing whitespace as part of the test should be manually set in editors/IDEs or by disabling the editorconfig for particular editing. - Add *.ac, *.d, *.l, *.skl, *.re, *.wsdl, *.dtd, *.html, *.rng, *.xml, *.xsd, *.xsl, buildconf, and Makefile* files settings.
PHP is so special that it needs two kinds of files for the same file type.
nikic
approved these changes
May 20, 2019
There was a problem hiding this comment.
Should be fine ... binary files are usually not edited in editor.
As a side-note, I wonder if we should change var_dump to print \0 for null bytes, I think that would avoid most of our binary phpt files and also possibly avoid user confusion when dumping mangled properties and similar.
|
By the way, I think we really need to do a full reindent of all phpt tests (and possibly also all php scripts) to spaces in 7.4/master. Updating existing tests is something of a PITA right now because you have about 50/50 chance of running into the wrong indentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Listing separate files is a mission impossible for EditorConfig. So, this now limits to changing only spaces and tabs settings for different file extensions. Targeting PHP-7.2 because the EditorConfig is useful setting when checking out different branches. And also adding *.wsdl files as noted in b15bfb9#comments
I'll recheck soon, if these can be applied to all files.