Add tests for DatePeriod properties

[duncan3dc]

While merging #3121 up I noticed that there appears to be a segfault introduced in the PHP-7.4 branch.

These tests pass on PHP-7.2, PHP-7.3, but they cause a segfault on PHP-7.4

[duncan3dc]

git bisect suggests that 1cfbb21 is the offending commit

[cmb69]

Aha! Looks like

php-src/ext/date/php_date.c

Line 2181 in 8380451

date_object_handlers_period.get_property_ptr_ptr = NULL;

is the culprit, since the get_property_ptr_ptr handler is now required.

[duncan3dc]

@cmb69 Thanks for the pointer!
I've added the required handler in fc8e1433c9e8a0eebb1b369013ad788493c8053 but I'm not sure if that's the appropriate way to handle it

[nikic]

I've applied the tests via 5d67271 to 7.2+ and added the missing handler in 3bd5b83. Thanks for catching this!

[nikic]

I've added the required handler in fc8e1433c9e8a0eebb1b369013ad788493c8053 but I'm not sure if that's the appropriate way to handle it

Whoops, looks like we worked on this at the same time. In this case there's no need to replicate the logic inside get_property_ptr_ptr, we just have to tell the engine that it should use read_property instead. Once properties on DatePeriod are permitted (#3121), it would be possible to use this handler for all the non-magic ones for improved performance.