Fix ast export in array

[sunnyeo]

zend_ast_export function has a bug when export an array with reference.
It misses reference sign (&).

Test case:

<?php
$var = 1;
$arr = array(&$var, $var);

Expected result:

$var = 1;
$arr = [&$var, $var];

Actual result:

$var = 1;
$arr = [$var, $var];

[sunnyeo]

Test case:

<?php
$var = 'test';
$str = "$var, $var[1], {$var}[], {$var[1]}[], ${var}[], ${var[1]}[]"

Expected result:

$var = 'test';
$str = "$var, {$var[1]}, {$var}[], {$var[1]}[], {$var}[], {$var[1]}[]"

Actual result:

$var = 'test';
$str = "$var, {$var[1]}, $var[], {$var[1]}[], $var[], {$var[1]}[]"

• If ZEND_AST_VAR's next list starts with [, ZEND_AST_VAR should be {ZEND_AST_VAR}.
  • $var[] --> {$var}[]
• If not, it occurs PHP Parse error: syntax error, unexpected ']', expecting '-' or identifier (T_STRING) or variable (T_VARIABLE) or number (T_NUM_STRING)

[nikic]

@sunnyeo Can you please add these as actual tests? Zend/tests/assert/expect_015.phpt can be used for this.

[nikic]

This code is becoming quite hard to read. Can you maybe extract a function zend_ast_var_needs_braces() that performs these checks?

[carusogabriel]

Maybe if is not necessary here:

Suggested change

	if (ch != '[' && !zend_ast_valid_var_char(ch))
	return ch != '[' && !zend_ast_valid_var_char(ch);