Skip to content

Add Calendar ext PHP stubs #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add Calendar ext PHP stubs #4552

wants to merge 1 commit into from

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Aug 17, 2019

@simPod
Copy link
Contributor Author

simPod commented Aug 19, 2019

@nikic thanks for review

php-pulls pushed a commit to php/doc-en that referenced this pull request Aug 20, 2019
salathe pushed a commit to salathe/phpdoc-en that referenced this pull request Aug 20, 2019
@cmb69
Copy link
Member

cmb69 commented Aug 20, 2019

Force-push after approval requires new review.

@simPod
Copy link
Contributor Author

simPod commented Aug 20, 2019

Ok, I thought I'd squash commits. Shouldn't I do it in other PRs?

@cmb69
Copy link
Member

cmb69 commented Aug 20, 2019

Well, if you only squashed, that should be okay. I suggest not to squash after review/approval, though; the merger can still do this if desired. I'll take care of this PR, if nobody beats me to it. :)

@cmb69 cmb69 self-assigned this Aug 20, 2019
@php-pulls php-pulls closed this in 3b2329d Aug 20, 2019
heiglandreas pushed a commit to phpdoctest/en that referenced this pull request Feb 4, 2020
salathe pushed a commit to salathe/phpdoc-en that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants