Update opcache return type info for gd functions #4785
Conversation
Many of these now have reflection types, making the old signatures redundant or inaccurate. (Some methods also throw Errors instead of returning null/false)
|
https://gist.github.com/TysonAndre/922f630d4cdae853580e9faad12a785e contains this and other inconsistencies or redundant annotations that are currently found in zend_func_info.c (with the extensions I have enabled) https://github.com/phan/phan/blob/master/internal/extract_arg_info.php was the script used to compare the latest reflection types and opcache's zend_func_info.c. |
|
The build failures are in tests unrelated to the gd extension and seem sporadic. e.g. php-src is failing on mac OS - Does gc has a small percentage chance of getting triggered on session close? https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=3136&view=ms.vss-test-web.build-test-results-tab&runId=65728&resultId=108473&paneView=debug |
|
@TysonAndre session issue should hopefully be fixed by 7d19668. |
Many of these now have reflection types,
making the old signatures redundant or inaccurate.
(Some methods also throw Errors instead of returning null/false)