Add stubs for IntlCalendar #4846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
force-pushed
the
intl-calendar
branch
from
d46a1b5 to
1f96f83
Compare
kocsismate
force-pushed
the
intl-calendar
branch
2 times, most recently
from
ebc6acd to
cac3128
Compare
|
Test failures are legit, make step fails. |
|
@Girgias Thanks for the heads up, now I see the issue. My other PRs where I pushed fixes also have similar problems. |
kocsismate
force-pushed
the
intl-calendar
branch
from
cac3128 to
28ce5a9
Compare
cmb69
reviewed
Nov 20, 2019
kocsismate
force-pushed
the
intl-calendar
branch
from
28ce5a9 to
8c7b3ee
Compare
kocsismate
commented
Nov 22, 2019
kocsismate
force-pushed
the
intl-calendar
branch
2 times, most recently
from
f8c776a to
277f3e4
Compare
|
Is it good to be merged? |
nikic
approved these changes
Feb 4, 2020
| co->ucal->set((int32_t)args[0], (int32_t)args[1], (int32_t)args[2]); | ||
| } else if (arg_num == 4) { | ||
| zend_argument_count_error("No variant with 4 arguments"); | ||
| return; |
ext/intl/calendar/calendar.stub.php
Outdated
|
|
||
| /** | ||
| * @param IntlTimeZone|DateTimeZone|string|null $timeZone | ||
| * @return IntlGregorianCalendar|null |
ext/intl/calendar/calendar.stub.php
Outdated
| /** @param IntlTimeZone|DateTimeZone|string|null $timeZone */ | ||
| function intlcal_create_instance($timeZone = null, ?string $locale = null): IntlCalendar|null {} | ||
|
|
||
| function intlcal_get_keyword_values_for_locale(string $key, string $locale, bool $commonlyUsed): Iterator|false {} |
kocsismate
force-pushed
the
intl-calendar
branch
from
277f3e4 to
2f266fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.