Fix $x = (bool)$x; with opcache (should emit undeclared variable notice) #4914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TysonAndre
force-pushed
the
fix-BOOL_NOT-undef-check
branch
from
1f82635 to
65157a8
Compare
|
If this gets merged from 7.2 into php 8.0, the test expectation should be a warning, not a notice |
And `$x = !$x` Noticed while working on phpGH-4912 The included test would not emit undefined variable errors in php 8.0 with opcache enabled. The command used: ``` php -d zend_extension=opcache.so --no-php-ini -d error_reporting=E_ALL \ -d opcache.file_cache= -d opcache.enable_cli=1 test.php ```
TysonAndre
force-pushed
the
fix-BOOL_NOT-undef-check
branch
from
65157a8 to
75ed894
Compare
TysonAndre
changed the title
|
Merged as a2c41c0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And
$x = !$xNoticed while working on GH-4912
The included test would not emit undefined variable errors in php 8.0
with opcache enabled. The command used: