Change Errors to ValueError #4930
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failures are related, will fix later today. |
nikic
reviewed
Nov 19, 2019
nikic
reviewed
Nov 19, 2019
nikic
reviewed
Nov 19, 2019
kocsismate
reviewed
Nov 19, 2019
ext/standard/array.c
Outdated
| @@ -2909,7 +2909,7 @@ PHP_FUNCTION(range) | |||
| } | |||
| err: | |||
| if (err) { | |||
| zend_throw_error(NULL, "step exceeds the specified range"); | |||
| zend_value_error("step exceeds the specified range"); | |||
There was a problem hiding this comment.
What do you think about also capitalizing the initial letter in order to match the others?
There was a problem hiding this comment.
I agree with that but I don't know if I should do this in the same commit.
There was a problem hiding this comment.
I agree with that but I don't know if I should do this in the same commit.
Girgias
commented
Nov 19, 2019
Girgias
commented
Nov 19, 2019
Girgias
force-pushed
the
change-to-value-error
branch
2 times, most recently
from
5f100a5 to
d82d10b
Compare
Girgias
force-pushed
the
change-to-value-error
branch
from
d82d10b to
8cb9c29
Compare
Girgias
force-pushed
the
change-to-value-error
branch
from
8cb9c29 to
eeabea2
Compare
nikic
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were made before the introduction of ValueError changing them all in one batch.