Also don't call other magic for uninitialized typed properties #4974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These cases are much less important, but for consistency we should treat all magic property methods the same with regard to how they handle uninitialized typed properties.
|
I have verified that this does not break ProxyManager (cc @Ocramius), presumably it always unsets all properties, regardless whether they're typed or not. |
|
@derickr I'd like to land this change for 7.4.1. If we make this change it should happen ASAP, before people start to rely on the behavior in a big way. |
Ocramius
approved these changes
Dec 6, 2019
|
Per discussion in chat, going forward with this. |
vvval
pushed a commit
to cycle/proxy-factory
that referenced
this pull request
Dec 24, 2019
See php/php-src#4974 Now ONLY FOR 7.4.0 <= php version < 7.4.1 proxy does not unset public typed properties with defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already changed the behavior for
__set()in f1848a4. However, it seems that this is also a problem for all the other property magic, see bug #78904.This commit makes the behavior of all the property magic consistent: Magic will not be triggered for uninitialized typed properties, only explicit unset() ones. This brings behavior more in line how non-typed properties behave and avoid WTF.
As this is a non-trivial behavior change, we should land this ASAP (in 7.4.1), otherwise our hands may be tied.