Skip to content

Fix F1 type information in OPCache #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Zend/zend_builtin_functions.c
Original file line number Diff line number Diff line change
Expand Up @@ -1630,7 +1630,7 @@ ZEND_FUNCTION(get_defined_vars)

symbol_table = zend_rebuild_symbol_table();
if (UNEXPECTED(symbol_table == NULL)) {
return;
RETURN_EMPTY_ARRAY();
}

RETURN_ARR(zend_array_dup(symbol_table));
Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_builtin_functions.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function get_declared_interfaces(): array {}

function get_defined_functions(bool $exclude_disabled = false): array {}

function get_defined_vars(): ?array {}
function get_defined_vars(): array {}

function get_resource_type($res): string {}

Expand Down
3 changes: 1 addition & 2 deletions Zend/zend_builtin_functions_arginfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@ ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_get_defined_functions, 0, 0, IS_
ZEND_ARG_TYPE_INFO(0, exclude_disabled, _IS_BOOL, 0)
ZEND_END_ARG_INFO()

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_get_defined_vars, 0, 0, IS_ARRAY, 1)
ZEND_END_ARG_INFO()
#define arginfo_get_defined_vars arginfo_get_included_files

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_get_resource_type, 0, 1, IS_STRING, 0)
ZEND_ARG_INFO(0, res)
Expand Down
18 changes: 9 additions & 9 deletions ext/bcmath/bcmath.stub.php
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
<?php

function bcadd(string $left_operand, string $right_operand, int $scale = UNKNOWN) : string {}
function bcadd(string $left_operand, string $right_operand, int $scale = UNKNOWN): string {}

function bcsub(string $left_operand, string $right_operand, int $scale = UNKNOWN) : string {}
function bcsub(string $left_operand, string $right_operand, int $scale = UNKNOWN): string {}

function bcmul(string $left_operand, string $right_operand, int $scale = UNKNOWN) : string {}
function bcmul(string $left_operand, string $right_operand, int $scale = UNKNOWN): string {}

function bcdiv(string $dividend, string $divisor, int $scale = UNKNOWN) : string {}
function bcdiv(string $dividend, string $divisor, int $scale = UNKNOWN): string {}

function bcmod(string $dividend, string $divisor, int $scale = UNKNOWN) : string {}
function bcmod(string $dividend, string $divisor, int $scale = UNKNOWN): string {}

function bcpowmod(string $base, string $exponent, string $modulus, int $scale = UNKNOWN): string|false {}

function bcpow(string $base, string $exponent, int $scale = UNKNOWN) : string {}
function bcpow(string $base, string $exponent, int $scale = UNKNOWN): string {}

function bcsqrt(string $operand, int $scale = UNKNOWN) : string {}
function bcsqrt(string $operand, int $scale = UNKNOWN): string {}

function bccomp(string $left_operand, string $right_operand, int $scale = UNKNOWN) : int {}
function bccomp(string $left_operand, string $right_operand, int $scale = UNKNOWN): int {}

function bcscale(int $scale = UNKNOWN) : int {}
function bcscale(int $scale = UNKNOWN): int {}
4 changes: 2 additions & 2 deletions ext/gd/gd.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,9 @@ function imagegetclip(GdImage $im): array {}
#ifdef HAVE_GD_FREETYPE
function imageftbbox(float $size, float $angle, string $font_file, string $text, array $extrainfo = UNKNOWN): array|false {}

function imagefttext(GdImage $im, float $size, float $angle, int $x, int $y, int $col, string $font_file, string $text, array $extrainfo = UNKNOWN) {}
function imagefttext(GdImage $im, float $size, float $angle, int $x, int $y, int $col, string $font_file, string $text, array $extrainfo = UNKNOWN): array|false {}

function imagettfbbox(float $size, float $angle, string $font_file, string $text) {}
function imagettfbbox(float $size, float $angle, string $font_file, string $text): array|false {}

function imagettftext(GdImage $im, float $size, float $angle, int $x, int $y, int $col, string $font_file, string $text) {}
#endif
Expand Down
2 changes: 1 addition & 1 deletion ext/hash/hash.c
Original file line number Diff line number Diff line change
Expand Up @@ -1329,7 +1329,7 @@ static const zend_function_entry hash_functions[] = {
PHP_FE(hash_copy, arginfo_hash_copy)

PHP_FE(hash_algos, arginfo_hash_algos)
PHP_FE(hash_hmac_algos, arginfo_hash_algos)
PHP_FE(hash_hmac_algos, arginfo_hash_hmac_algos)
PHP_FE(hash_pbkdf2, arginfo_hash_pbkdf2)
PHP_FE(hash_equals, arginfo_hash_equals)
PHP_FE(hash_hkdf, arginfo_hash_hkdf)
Expand Down
4 changes: 3 additions & 1 deletion ext/hash/hash.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,15 @@ function hash_copy(HashContext $context): HashContext {}

function hash_algos(): array {}

function hash_hmac_algos(): array {}

function hash_pbkdf2(string $algo, string $password, string $salt, int $iterations, int $length = 0, bool $raw_output = false): string {}

/**
* @param $known_string no type juggling is performed
* @param $user_string no type juggling is performed
*/
function hash_equals(string $known_string, string $user_string) : bool {}
function hash_equals(string $known_string, string $user_string): bool {}

function hash_hkdf(string $algo, string $ikm, int $length = 0, string $info = '', string $salt = ''): string {}

Expand Down
2 changes: 2 additions & 0 deletions ext/hash/hash_arginfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ ZEND_END_ARG_INFO()
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_hash_algos, 0, 0, IS_ARRAY, 0)
ZEND_END_ARG_INFO()

#define arginfo_hash_hmac_algos arginfo_hash_algos

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_hash_pbkdf2, 0, 4, IS_STRING, 0)
ZEND_ARG_TYPE_INFO(0, algo, IS_STRING, 0)
ZEND_ARG_TYPE_INFO(0, password, IS_STRING, 0)
Expand Down
Loading