Cleanup & fix openssl handling in configure #5091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
commented
Jan 17, 2020
| [AS_HELP_STRING([[--with-openssl-dir[=DIR]]], | ||
| [FTP: openssl install prefix])], | ||
| [no], | ||
| [no]) |
There was a problem hiding this comment.
After thinking about this a bit more, I don't think we can drop these, because they're the only way to force enable SSL support if you only want to build the ftp ext (without the openssl ext). This should probably be something like --with-ftp-ssl similar to the imap option.
But to avoid BC break for 7.4, we should probably just keep this as-is and just change the message to not talk about prefixes.
|
Per my comment above, I'm now no longer removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove leftover references to
--with-openssl-dir, which is not used, as the openssl path is now determined by pkg-config.Also remove the check of
PHP_OPENSSLinsideSETUP_OPENSSL. It's the responsibility of the caller to determine whether they want to enable openssl or not. This should also make IMAP with SSL work, which uses a different option.