Add preg_last_error_msg() function #5185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable. I'd suggest sending a mail to the internals mailing list about this. If the addition is not controversial, then we can add it without a full RFC. |
nikic
reviewed
Feb 18, 2020
Thank you! I'll do that! |
nicoSWD
commented
Feb 19, 2020
|
Perhaps you didn't know, there's a wrapper library for regexps in PHP, and it already has |
added 2 commits
February 20, 2020 18:11
|
@nikic Looks like there weren't any objections or concerns regarding this. Is there anything else I should do? |
nikic
approved these changes
Feb 24, 2020
|
Thank you, @nikic! Will this be part of PHP 8, or an earlier release? |
|
@nicoSWD This will be part of PHP 8.0. |
nicolas-grekas
added a commit
to symfony/polyfill
that referenced
this pull request
Feb 27, 2020
This PR was squashed before being merged into the 1.14-dev branch. Discussion ---------- [PHP 8.0] Add preg_last_error_msg function This PR adds the function `preg_last_error_msg` added in [php-src/pull/5185](php/php-src#5185) _Note_: I only tested the cases that don't require special `.ini` settings as I didn't want to set them dynamically in the test suite. Commits ------- 151806f [PHP 8.0] Add preg_last_error_msg function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new PCRE function called
preg_last_error_msgwhich returns a human-friendly string representation of the last error.Seeing as most comments in the preg_last_error() documentation are about converting the error codes to meaningful messages, I see no reason why this shouldn't be supported natively.
The JSON extension also provides two separate functions for both use-cases.
And so do many others, such as
etc...
So to me it feels natural for this function to exist. The naming scheme seems faily inconsistent, but I like the
_msgsuffix the most.Thoughts? And does this need an RFC?
Edit:
For reference, here's the PHP internals discussion:
https://externals.io/message/108665