Fix #76999: mb-regex-set-options return current options #5264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting new options, `mb_regex_set_options()` is supposed to return the *previous* options.
|
This is obviously a BC break, but now the function behaves as documented. Alternative: change documentation, but keep the function's behavior. |
|
IMHO it's better to change the function as most of our setter function return the previous option IIRC |
|
I think we should do this, but not for 7.3. 7.4/master should be fine. |
|
Okay, applied to master as 9e77d5a. |
cmb69
added a commit
to cmb69/doc-en
that referenced
this pull request
Mar 27, 2020
php-pulls
pushed a commit
to php/doc-en
that referenced
this pull request
Oct 7, 2020
Cf. <php/php-src#5264>. git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@350810 c90b9560-bf6c-de11-be94-00142212c4b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting new options,
mb_regex_set_options()is supposed toreturn the previous options.