Skip to content

Remove XFAIL section of a passing COM test #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Mar 25, 2020

No description provided.

Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weltling as you introduced it, mind to review?

@Girgias you should remove the comments as well introduced few commits back in this file.

@cmb69
Copy link
Member

cmb69 commented Mar 25, 2020

Well, I wonder what to do with this test for quite a while. I guess we can remove the XFAIL section (and the respective comment as Gabriel pointed out) for master.

@Girgias
Copy link
Member Author

Girgias commented Mar 25, 2020

Well, I wonder what to do with this test for quite a while. I guess we can remove the XFAIL section (and the respective comment as Gabriel pointed out) for master.

ACK, should I commit directly to git.php.net?

@Girgias Girgias force-pushed the drop-xfail-flag-com-test branch from 4bec0f0 to bdf37b8 Compare March 27, 2020 01:33
@php-pulls php-pulls closed this in af63050 Apr 14, 2020
@Girgias Girgias deleted the drop-xfail-flag-com-test branch April 14, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants