Show diffs for failed tests on i386/Mac OS CI

[alexdowad]

Seeing the diffs for failed tests in CI is very helpful, especially for developers who do not have a Mac (or other test platform in question).

[nikic]

Diffs are available under the "Tests" tab, see for example https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=7824&view=ms.vss-test-web.build-test-results-tab.

[alexdowad]

Diffs are available under the "Tests" tab, see for example https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=7824&view=ms.vss-test-web.build-test-results-tab.

Thanks. Though I don't see any test diffs from following that link.

[nikic]

You should see diffs if you click on one of the failing tests, such as https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=7824&view=ms.vss-test-web.build-test-results-tab&runId=177842&resultId=112026&paneView=debug.

[Girgias]

The test tab on Azure sometimes decide to hide itself for no apparent reason (at least that's what I experience)

[alexdowad]

The test tab on Azure sometimes decide to hide itself for no apparent reason (at least that's what I experience)

I think for me it's not "sometimes" but "all the time". This is what I see from both of the links shared by @nikic:

[alexdowad]

Anyways, I can just make this change on my own dev branches and then git rebase --interactive it out before opening a PR.

[nikic]

Waaat. I just tried this in private browsing mode and I don't see the Tests tab either. Maybe it's only visible to member of the PHP org?

[nikic]

I found some permissions related to this, but I couldn't figure out how to make this visible for everyone. And I think that this did used to work previously...

I've opened a ticket at https://developercommunity.visualstudio.com/content/problem/1045997/tests-tab-not-visible-for-logged-out-users-on-open.html, but for now your change here seems fine as a workaround. I'd add it to the main linux x64 job as well, it shouldn't hurt at least.

[alexdowad]

I found some permissions related to this, but I couldn't figure out how to make this visible for everyone. And I think that this did used to work previously...

I've opened a ticket at https://developercommunity.visualstudio.com/content/problem/1045997/tests-tab-not-visible-for-logged-out-users-on-open.html, but for now your change here seems fine as a workaround. I'd add it to the main linux x64 job as well, it shouldn't hurt at least.

Should I reopen the PR, then?

[nikic]

Yeah

[kocsismate]

I can also confirm that tab started to be missing for me as well since the last couple of days/weeks.

[cmb69]

Chrome dev-tools heavily complain for that page.

[nikic]

Can you please add it to azure/test.yml as well?

[alexdowad]

Can you please add it to azure/test.yml as well?

Thanks for the suggestion. Done.

[nikic]

Uh, for some reason a bunch of 32-bit tests fail now.

[alexdowad]

Uh, for some reason a bunch of 32-bit tests fail now.

I don't have time right now, but I'll be happy to investigate later and see what is happening.

[nikic]

Okay, those test failures are not related to this PR, also seeing them on https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=7846&view=results. @cmb69 Quite likely this is from the FPU precision change. But for some reason on master only. Maybe because master uses serialize_precision for var_dump.