Fail in ./configure when no opcache shm backends exist
#5615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be more useful to detect this directly in config.m4 and error if none of the configure checks passed. |
This can be seen when the `./configure` step fails to detect `HAVE_SHM_*`, e.g. due to missing a necessary dependency to compile the test scripts. (Run `./configure`, run `yum install libtool-ltdl-devel` for missing dependencies, then run `make`, and php can end up built with 0 shared memory opcache caches) Give a clearer error message than `unknown` Searching for `opcache "Fatal Error Unable to allocate shared memory segment of" "unknown: No such file or directory"` reveals issues such as termux/termux-packages#2234
TysonAndre
force-pushed
the
shared-memory-handler-implementation
branch
from
16da244 to
14d6453
Compare
TysonAndre
changed the title
./configure when no opcache shm backends exist
Done, wasn't sure if this was deliberately allowed for a minority of systems without shared memory support (e.g. file_cache_only can work around it) |
nikic
approved these changes
May 24, 2020
The travis build failure seems unrelated, windows builds(appveyor) would be unaffected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be seen when the
./configurestep fails to detectHAVE_SHM_*,e.g. due to missing a necessary dependency to compile the test scripts.
(Run
./configure, runmake, then runyum install libtool-ltdl-develfor missing dependencies,then run
make)Prevent creating builds of php where running with opcache results in
unknown.Searching for
opcache "Fatal Error Unable to allocate shared memory segment of" "unknown: No such file or directory"reveals issues such astermux/termux-packages#2234