Constify char* arguments of APIs #5676

twose · 2020-06-07T02:29:49Z

No description provided.

twose · 2020-06-07T02:31:11Z

ext/standard/info.h

@@ -52,13 +52,12 @@
 #define ZEND_LOGO_DATA_URI "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAPoAAAAvCAYAAADKH9ehAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAEWJJREFUeNrsXQl0VNUZvjNJSAgEAxHCGsNitSBFxB1l0boUW1pp3VAUrKLWKgUPUlEB13K0Yq1alaXWuh5EadWK1F0s1gJaoaCgQDRKBBJDVhKSzPR+zPfg5vLevCUzmZnwvnP+k8ybN3fevfff73/vBAJTHxc+khL5kr6T1ODk5nAgTRTWloghFVtEg/zfh2PkSvq9pJGSKiX9SdKittbJoD/PSYkrJD0vKeB4IsNNotfuUtHk/CM+IvijpF9KGiDpGEkLJZ3lC7qPeKKTpD9IWiDpUOfWPCi61ZeLvD2VIhTwp9QlTjK5NsIXdB/xxHmSpvD/OucWPSAyQw2+LfeG1SbXVra1Tqb785xUaNdMel0g7Iu5V1zPv6dJqpD0kKR/+ILuI55o8oeg1bFT0kWSOkraQxK+oPvw0TZR3ZY758foyQXf//ZxUFh0Q/GEfNf9gHkaJ6m7pHJJSyTt9tnXhxtBR2EGlnHCMbZMaHuHzX19JZ0u6VRJh0k6hM+BpMjnklZIelPSNhff3V5StkNlEWBMFm+3LcC+BW3GuZP2GvfmiEiCCMUzxZIKRGSt9zeML/fdGAW9JB3O8c6SlMZ+b5f0qaQiF7EpnieXY1auvZfG7zhSUk8RSS428F7M5xfsh1eAV/vxOzoq16sklZBqbdpo5H2qDPRQXoP3Ki0+20FSFyrZUgt+Rt/7KH2vZb8/t/iMG2Sy/0dI6sbvgHGoV8a3xErQb5Q0iTfHCplkzlkW7w+VNF3ST7QJUzFK0pVkDFiw+yV95uC7r5Z0k3CW2ApwIkrJ9B9IelfSh2SIlqC/pDFUZAVk0rQoMhk2GYswx+AtWvMKPtcyEckW37pPwsIHNAuBniDpYhEpBMmJwvibJL0gIlVh39r0C8UlczkXQ/mM6OtEzuf3RfPVAxUY47f5PStcGKPxpOMldbbxiBptPMavJX1PuQ/P/olyz12S7rD4PLyqBTQ8gyXVSOot6VK+dxR53wyl7POjkv7pkpcwpleJSCHP4eQjM0BB/ZuG4Hl9EO8mQx4ZQ0FfL+k+k+t4wNlULpkO24IGnSzpQklzKPDRAMvZ1eXz9uXfH/Pvx5Ie44C5zYQXUgDPj6LEnMCQ3AFkjjupjGF9/kJmxPw1oiquz+6dalXcCRSmYxwK0kDSRI71azb3Y+6GiMi6P/5ey3F3YpExjxdQoG61uX8gBetkh2OWFkUIVGUT1pS9yosZNu1nkl8uZH+mikhxkx1wz7mkB0WkXsKJFw1ZuSWKotY9wjNJS6mUy41JK5P0c2qCnBgIeQWZvEK7Dnf6WUljTT5TS7d0KwezkJShdWIeGeuKKJo7FktUQylcl0i6RtL/HH4OjP+wB0UTLTGHfubRDWyi1g7SaoZQ495z9w7RpaHKqHEfLeklEyWzk+7dl3TTu1KQCpV7+pBB4IWstFFAgvOpJnTL6DoW0xPbw3k/nIYkW+kbmHeXhUEABklazrBDBdzTDfyuBo5DPq1eoUk7ZbSk70l6n3MZjUdCDpQvMF/rezn7/hX7Xs8wsj/7rsrWdQxnZtrwwENUosJkDDZxTjOUkEH1ds6lzJyDZzGScRsonGNcMCIG+WgRKTRQ8Su2p7uRi/mlKjZKekREChS2KIOcTvfqp3RZDlM+cxnfv8Thc75Pt8kqo92VzNTbxBqcQlceivAdByHDIxbvFTMOLovyHAGGK3qc/jJDoDc4hpjABzBm4UAglBFqEAOqt8mB29ss4uJnNCHfSK/tVZMYEfMykt7Bcco1eDLDHCT8gmzzRdLHZL6wRSgzg6GIgVl8Xj2uhPA+oQn53yTdK2mVMC8NzuJ8zaSyM/ApxyzWCFJRvUQ3eQ29BTNFcRgt+FTl2g30zDZZtD/ZRMifE5ES6Y9MxqAHQ7XZikI9nd97j5p1f83GZTPr6Crt2sOcOB1zTYT8HrqjVRZx4wbSAt47SXn/YsZV9zp4zuvJgNGQRaszmoN1rBY6IH4dHiVHcA5dZd2zeIbPv8ZBkghYTQFTx/h1WvSz6c3kM5ewGG8Prvxc5DZWS2u+dypnM5Y3sIJMXmbxfXW0misZN56oxITnWsyl2fg+6+C+zWTefMWr68RwaYF271htHBZqCsKqL28wB/ACjYShrE9nUjfWmEU33A7woqbR4k5UlNk4yoYOzOHvtGs30KO1QgnlZC2VohGOIGn7WEvW0ZdoMeCHfBgdo8X++m3V+s2wEHKzJMblJom92+ne2SHDwT1gknUispPpJLrrVZqwLxTmy5F5jOdVS72F/b6UwlbrcEytrD00+a8l/ZUM82jEZd8peu8uNYS8JxNWqis5IYqQCy1rPUULh8Y7fOYal3zzmPb6aJN7zlf+32bBV9ESclNE85WUX4j4oNbl/fM1b2eoxX3jyXNqiDTP4Xe8Rm9ItfSjvAr6DM0d+o5MXW/CuHO0a7eZTLYT3KF9LktYZ/WdCI+IkoV+lFZ6l3J9OF14HdM0F3MrhXxFjJmqhh5FBera24XqxaCqL0UosK97Z2ku+yJaEqf4D62ByoROcjZuN78Xaa9zTBSzKvxvC+vlrmgWVPU2h4j4FCO5lZ+vNBnpYHHfOOX/PfR83eApTaGM8CLop5l88WSLWAOu4AiNme5owcBO1xhlLGO/eGAFkyYqrtFe5zKzqU7KBE5o/BAIiv7VJSK7qV4GhEF1XtSk0YseWl6lWYI+cXj6pigJLkH3Vk0qfebxe4q0JGOGSDxCWn/Nchk9qJgMfGKS87LDes1IHeVW0LszgaC6sPMYE5lBt4CzRcuy4lVMLKlWfWwcJ+YpxtcGjtOYfzRjTgNIlv0rnpyCveeHNFSJ/jUlonH/3nNYqyOU28qYhHOLbzVPqFc81JQDKxnQ5twLdmjfmQzlxU6eoZ/mma3y8D3VonlhUr6bElhMwJ81RseSxW+jfOYULdYGAw5s4WBtpeU0ijKwxnp/HCfn70piCNlMFEUU8/WpmnZe1Bq80r96m5yMkIwx9nnNHTWFs114q0ArM1HsiUY7j5/rKFIThdrrzR7agHyoy9vd3Ag64uEfKa+xjIKlLqtTUBB7FWgJrQ9joFl1d2cQ2wzHaeDXa6/ztO9Wx+OT+FrzSAKuV12ptOZp+ljnaVawk8uxDpnMZXYCGB3PXqe5sl7QQ5ubhhQR9B4mQpvjIR+gJgrbOxV0rK/rVUyXmyRWdI2a2YLEhVP3BwmN9sJ9BtQpKkxiSDOrUeUhaeQaPevKzKQ3oIVTSGatcynoRl29sIkh440a8pURNoz00Ab4Ts1obxCps1FKl8k5IpKbcmsgu6nz6ETQC+iSqoKKOPmVJBmYnDjHX4EozB9s7TgwykkyYS13URAHpmstYIloOP/HEi6Wx5a4+DwSpH2V18tTyHUPm3iQeS1s09ai4/0ntVgNRQmzHTRulGwaQNnei3FgHqPcMBEJlXrNioAaE8AcupKBd7ElBu1uTxCzg+dmKB4TahiQNX/OxssAb00Uzdeci4S3FYhEQdfkWCrc1cI2K+2EDhsP1OUxZGUnOWTmcgphV0UgZ4jUR1hLlBiuJfqJpb61CXimOrq8RqiEeu6TU3iMwdzYgWhUnWHDDKr0ptLar6USqmOfYYiGMMTUN/KgziGVTo+pNJHBBfF0zVAQc6N2DUL+tcO2Yc1Rk2ss+yBmOko43yCSCljJXAWA7PD4eAt6MBy2yiNACRvVVN05t40pPLYPsT+zlRDpOLG/Jt8OSGKhmnBpivV7q/Y6JkucVgkyWKb52rVZwl0tvNDi+AzRvKjfK1Dnjvpd1FhPEc1LBVsbqENXN35cFaPY2BIVGdlWYZKqgPPj/RythNtpcNycpoOxwAae0bGwhAkAQg01cfiDWDRqZtHhCqFQ5FAtOXKXh/Yh6Ci2N5YMUDW2SHg/N3scn02N++cnMIZCBdwS9gtApRxqDc6OlzWtSrdc8cJGlzP5fzZDri1tQNixISWL/5fSQvcVzfe/wzXfSG8Kuw03pHB/t5KMik+EYJ1EC1d0zCw6fofqRI2ZJwpvyxN4uPs0q/6UR2szyESobxatf3aa7jvfrT0DGPNpYV3H3CI0BYLGllQdy7TX14rUP/zzDHpuRp0EPLnJvH68Qij/RXnyIyku5Ea+5S3NO7s01q77eMY1qqY8T7Qs+4qtq+o2UWhjZO6HuWhjJBlZXWbAHvbFSTAxqMW+RbuG3VfviAP36tshujINh6Tr3kE0BNMl5x8Qq6+mVTdwrMlzpRrGaGPzVpw9NDNFngjoFZZzRCS/FRPXHRZT31X2MgfYTQYX1WE1moaaQJfKEFTs/camkXnUwt9YtNWPiuc67VmRlb0yiRgS/cAe7is0QXuTAm9kikM2DNc5OkeGRaMU8tq0TJHbUCOtezMeRfITiSv1PLLbGE5gb/NOB/1AuR1KlLETDltidyR4XIPasyEnc6eIbRa9kfNifFeXJOAnVJBiKfFCvobcLKccLHWojHJpIPH3iXQlpoNLrdcH44sucvmQOHHjZ9rDrGdbixVmbk/XGy4mtiKuoQDjmQpFJLs6wuSZvqKmL0ky6zOZLry+420UKUaue5ooyeqy9+iopgM989cp1Dcp16bSU1tOJbyFyjedTID5wOk6OAUFFXUDKFRLkmBM3xH7fzIJwPLsxexDMWP2b8g38DqN45ywCuH0VNuv+XmjwOYCjtUakbg6AkGlNoQGBMB5A9g8hh2g7zFE2U4F35FxfHfmwwbxcz3Yl32C/oAwPwDAS6UXdpOhXPZ27Trc9R/SLTla0zzGoXl2QAexnLVZJB/CZMpV7HthfL4lJIrb54u+tdv3/rCiSbw+k88yM9ZxXgKwlHmZycq13iSr0KeMHmUZw6r1VICrLT4D5fy4wq/5DAvfjaWC9oAd9KxwTNUJynUjL+EqpwSTME1zOWMBuIxmZ7p9RCsNq+NmdxW09I1MdNkJeYZNHsIt0qKEO2Z4kvmHadS+Xqv2cqzc93rpuhdl54tg2DISuJljBW3uZjMHrAPqHOYK6zPIM23G2+14Rts4cyLbdxo3Y667UskOo/W/m/PwRhQBwZFkT2vXzDbTtLMZCyfP1155bbfDrpjKZoYH41bO+d97jmEgMPVxFMF0iHESIkiNtDhKuwV058cw0dBZNP+lFsSU/6VWf0E4P/x+IF2eJnokr4uW/2jAKPYjjRb7Cxef70c3qsCl0im1Gj/Uu2eF6sWo0rUiTQq7zS+pYjywnXYwcyOZfI4mKgHj9N2ttHqbRfSlQXhjw5XXy4S7ZbzOovkxVRsphHp8ia3HlyleZS1zHcvoVrdjuNFdEe7edGHzSbpSria/WZ3+cxYV5DCx/4w7FUfyfTW0WO+i7x2YrzKUXZFw/sut+OxJDGkHUxEZPwgCquQcIgxZR9oXekDQk8FF60bqwocupaIoEz6EmaC3C+0Ro6Wgp4eb2tpPJqN+4xXFXQ3TfUfCc5PDNnLZDpLIV1NADKyjZa87mHgmWX57bYdIfIY3pdCGf43xQUXI62kBn3fZxi4SPC8crIjDQ4yzFAaz/XcPJn7xf03VRzIB5Z7qCbBzPQi5jga2E9bCD+ELug8ficEZCk/Cmj8Ro3aLtLxDR1/QffhIHNRTUZCf+S5G7SJBp2b7G31B9+EjcVAFEInZQ2LU7jiN1zf4gu7DR+KwTvkfO9bGx6BNnEQ8XXmN5cT3fEH34SNxwN4A9dgknIEwyWNbeRTwV7WYHBVwFQfbwKb7vOUjiYAiKVT1PczXqCLD/n5UbuLcNxTKoCgExSFNmsFCHI6iJBQFnUbqqbWPHyFceDAOrC/oPpIN+FVaVLrNUa6dLPbvoEQdO4pd1OUylBVkCutsOkqosbNvwcE6qL6g+0hG3MY4ejots1pT3kE4P9QDdfuLKeDfHswD6gu6j2TF2yQcLoqEGurre9EdP1QTfmxJRdn0NlrvD+jmY69Egz+UQvxfgAEALJ4EcRDa/toAAAAASUVORK5CYII="

 BEGIN_EXTERN_C()
-PHPAPI zend_string *php_info_html_esc(char *string);
-PHPAPI void php_info_html_esc_write(char *string, int str_len);


I can not find any implementation of php_info_html_esc_write

The definition of php_info_html_esc_write() has been removed in PHP 5.4, so the declaration can be removed as well.

twose · 2020-06-07T02:33:41Z

main/php_variables.c

-		while (ss) {
-			space = strchr(ss, '+');
-			if (space) {
-				*space = '\0';


Notice: the original implementation used a hack way so I made some changes here

ext/date/php_date.c

twose · 2020-06-07T02:35:53Z

ext/session/php_session.h

@@ -260,12 +260,11 @@ PHPAPI int php_session_register_serializer(const char *name,
 	        zend_string *(*encode)(PS_SERIALIZER_ENCODE_ARGS),
 	        int (*decode)(PS_SERIALIZER_DECODE_ARGS));

-PHPAPI void php_session_set_id(char *id);


I can not find any implementation of php_session_set_id

twose · 2020-06-07T02:37:32Z

ext/standard/dl.c

 }

-#else


Notice: missing function implementations here, so I made some changes

nikic · 2020-06-07T08:44:07Z

Build failure on AppVeyor:

ext\standard\mail.c(504): error C2220: the following warning is treated as an error
ext\standard\mail.c(504): warning C4090: 'function': different 'const' qualifiers
ext\standard\mail.c(504): warning C4090: 'function': different 'const' qualifiers
ext\standard\mail.c(504): warning C4090: 'function': different 'const' qualifiers

twose · 2020-06-07T09:05:29Z

Build failure on AppVeyor:

ext\standard\mail.c(504): error C2220: the following warning is treated as an error
ext\standard\mail.c(504): warning C4090: 'function': different 'const' qualifiers
ext\standard\mail.c(504): warning C4090: 'function': different 'const' qualifiers
ext\standard\mail.c(504): warning C4090: 'function': different 'const' qualifiers

The deeper code is a bit more complicated so I just convert these pointers to char* now

cmb69 · 2020-06-07T11:02:37Z

The deeper code is a bit more complicated so I just convert these pointers to char* now

I think the following would do:

 ext/standard/mail.c | 2 +-
 win32/sendmail.c    | 8 ++++----
 win32/sendmail.h    | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/ext/standard/mail.c b/ext/standard/mail.c
index 61454a4930..b13acc82b7 100644
--- a/ext/standard/mail.c
+++ b/ext/standard/mail.c
@@ -501,7 +501,7 @@ PHPAPI int php_mail(const char *to, const char *subject, const char *message, co
 	if (!sendmail_path) {
 #ifdef PHP_WIN32
 		/* handle old style win smtp sending */
-		if (TSendMail(INI_STR("SMTP"), &tsm_err, &tsm_errmsg, hdr, (char *) subject, (char *) to, (char *) message, NULL, NULL, NULL) == FAILURE) {
+		if (TSendMail(INI_STR("SMTP"), &tsm_err, &tsm_errmsg, hdr, subject, to, message, NULL, NULL, NULL) == FAILURE) {
 			if (tsm_errmsg) {
 				php_error_docref(NULL, E_WARNING, "%s", tsm_errmsg);
 				efree(tsm_errmsg);
diff --git a/win32/sendmail.c b/win32/sendmail.c
index 281c343533..67253a3b79 100644
--- a/win32/sendmail.c
+++ b/win32/sendmail.c
@@ -177,7 +177,7 @@ static zend_string *php_win32_mail_trim_header(char *header)
 //  See SendText() for additional args!
 //********************************************************************/
 PHPAPI int TSendMail(char *host, int *error, char **error_message,
-			  char *headers, char *Subject, char *mailTo, char *data,
+			  char *headers, const char *Subject, const char *mailTo, const char *data,
 			  char *mailCc, char *mailBcc, char *mailRPath)
 {
 	int ret;
@@ -352,7 +352,7 @@ PHPAPI char *GetSMErrorText(int index)
 // Author/Date:  jcar 20/9/96
 // History:
 //*******************************************************************/
-static int SendText(char *RPath, char *Subject, char *mailTo, char *mailCc, char *mailBcc, char *data,
+static int SendText(char *RPath, const char *Subject, const char *mailTo, char *mailCc, char *mailBcc, const char *data,
 			 char *headers, char *headers_lc, char **error_message)
 {
 	int res;
@@ -633,7 +633,7 @@ static int SendText(char *RPath, char *Subject, char *mailTo, char *mailCc, char
 	return (SUCCESS);
 }
 
-static int addToHeader(char **header_buffer, const char *specifier, char *string)
+static int addToHeader(char **header_buffer, const char *specifier, const char *string)
 {
 	*header_buffer = erealloc(*header_buffer, strlen(*header_buffer) + strlen(specifier) + strlen(string) + 1);
 	sprintf(*header_buffer + strlen(*header_buffer), specifier, string);
@@ -651,7 +651,7 @@ static int addToHeader(char **header_buffer, const char *specifier, char *string
 // Author/Date:  jcar 20/9/96
 // History:
 //********************************************************************/
-static int PostHeader(char *RPath, char *Subject, char *mailTo, char *xheaders)
+static int PostHeader(char *RPath, const char *Subject, const char *mailTo, char *xheaders)
 {
 	/* Print message header according to RFC 822 */
 	/* Return-path, Received, Date, From, Subject, Sender, To, cc */
diff --git a/win32/sendmail.h b/win32/sendmail.h
index bb502cb7dd..a35851acf8 100644
--- a/win32/sendmail.h
+++ b/win32/sendmail.h
@@ -33,15 +33,15 @@
 
 
 PHPAPI int TSendMail(char *smtpaddr, int *returnerror, char **error_message,
-			  char *RPath, char *Subject, char *mailTo, char *data,
+			  char *RPath, const char *Subject, const char *mailTo, const char *data,
 			  char *mailCc, char *mailBcc, char *mailRPath);
 PHPAPI void TSMClose(void);
-static int SendText(char *RPath, char *Subject, char *mailTo, char *mailCc, char *mailBcc, char *data,
+static int SendText(char *RPath, const char *Subject, const char *mailTo, char *mailCc, char *mailBcc, const char *data,
 			 char *headers, char *headers_lc, char **error_message);
 PHPAPI char *GetSMErrorText(int index);
 
 static int MailConnect();
-static int PostHeader(char *RPath, char *Subject, char *mailTo, char *xheaders);
+static int PostHeader(char *RPath, const char *Subject, const char *mailTo, char *xheaders);
 static int Post(LPCSTR msg);
 static int Ack(char **server_response);
 static unsigned long GetAddr(LPSTR szHost);

twose · 2020-06-07T11:21:10Z

@cmb69 Thank you, I am a bit lazy 🤪

nikic

Nice work!

nikic · 2020-06-07T15:38:07Z

ext/date/php_date.c

 {
 	timelib_time *parsed_time;
 	timelib_error_container *error = NULL;
 	int           error2;
 	zend_long   retval;

-	parsed_time = timelib_strtotime(string, strlen(string), &error, DATE_TIMEZONEDB, php_date_parse_tzfile_wrapper);
+	parsed_time = timelib_strtotime((char *) string, strlen(string), &error, DATE_TIMEZONEDB, php_date_parse_tzfile_wrapper);


Could you please also submit a PR to https://github.com/derickr/timelib, so we can drop these const casts in the future?

I did not change it because I was worried whether this modification will affect other projects
but I will try to submit a PR soon

Added TODO comment

@nikic @derickr done: derickr/timelib#82

ext/date/php_date.c

ext/session/php_session.h

ext/standard/basic_functions.c

ext/standard/mail.c

main/php_variables.c

…of input)

twose · 2020-06-08T07:03:40Z

compilation passed

nikic

Wow, this has really blown up!

nikic · 2020-06-08T07:48:19Z

ext/phar/phar_object.c

@@ -805,7 +805,7 @@ PHP_METHOD(Phar, webPhar)

 			sapi_header_op(SAPI_HEADER_REPLACE, &ctr);
 			sapi_send_headers();
-			efree(ctr.line);
+			efree((void *) ctr.line);


The ctr.line related changes look a bit dubious to me. Do we gain anything by making it const char?

it only receives a read-only string in most cases

main/SAPI.c

nikic · 2020-06-08T08:00:05Z

ext/standard/head.c

 	size_t len = 0;

 	ZEND_PARSE_PARAMETERS_START(0, 1)
 		Z_PARAM_OPTIONAL
-		Z_PARAM_STRING(ctr.line, len)
+		Z_PARAM_STRING(line, len)


This makes me wonder why the Z_PARAM_STRING target is char ** and not const char **. Maybe we should change that as well (but separately -- it may have larger fallout).

I couldn't agree more, that's what I thought a long time ago
but if we change it, it may break many PECL extensions. and we can't reflect it is read-only when we use Z_PARAM_STR

Yeah, I'm not sure what to do about this one. With the old zend_parse_parameters API, it was possible to use both const char and char, because it simply wasn't validated. With Z_PARAM_STRING it is, and the wrong one has been originally used :(

For the zend_string APIs, I don't think "const" concept makes a lot of sense, because semantics are determined by copy-on-write. Effectively zend_string is "always" const (apart from refcount changes).

I think it may be appropriate to fix it in PHP8 because we already have a lot of BC breaks 🤪...

twose commented Jun 7, 2020

View reviewed changes

ext/date/php_date.c Outdated Show resolved Hide resolved

twose commented Jun 7, 2020

View reviewed changes

ext/standard/dl.c

}

#else

Copy link

Member Author

twose Jun 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice: missing function implementations here, so I made some changes

Constify char* arguments of APIs

f7ddeaf

twose force-pushed the constify-2020 branch from 91615eb to f7ddeaf Compare June 7, 2020 09:01

Fix compilation on WIN (apply the patch from @cmb69)

099c034

nikic reviewed Jun 7, 2020

View reviewed changes

twose added 7 commits June 8, 2020 00:13

Constify hdr

b9b9685

Optimizations

caafc3d

Constify more API char* arguments

4dd44bc

Constify char* arguments of SAPIs

5210949

Fix orig_getenv

9698bf7

Do not drop const qualifier

b4ad3cf

Fix OpenSSL compilation

19c00d6

twose force-pushed the constify-2020 branch 2 times, most recently from 3594d84 to 3cdfe9c Compare June 7, 2020 19:22

Fix PCRE compilation

99a1dd0

twose force-pushed the constify-2020 branch from 3cdfe9c to 99a1dd0 Compare June 8, 2020 02:14

twose added 5 commits June 8, 2020 10:21

Fix SAPI compilation

32fc777

Fix PDO compilation

0c01dbf

Fix PHAR compilation

e82bf5e

Fix head compilation

17ed118

Fix getenv function

1e6128b

twose mentioned this pull request Jun 8, 2020

Constify some char* arguments of all APIs derickr/timelib#82

Closed

Fix SAPI compilation again

67ab3cf

twose force-pushed the constify-2020 branch from 50856fd to 67ab3cf Compare June 8, 2020 04:36

twose added 2 commits June 8, 2020 12:43

Fix CLI server compilation

23f5adb

Fix fcgi_apply_func

92bc94e

twose force-pushed the constify-2020 branch 2 times, most recently from 3dbddc3 to df2a329 Compare June 8, 2020 05:41

Fix PHPDBG compilation (phpdbg_parse_variable may modify the content …

f07d66c

…of input)

twose force-pushed the constify-2020 branch 2 times, most recently from dcab466 to 406d58d Compare June 8, 2020 06:44

Fix sendmail on WIN

8f58f05

twose force-pushed the constify-2020 branch from 406d58d to 8f58f05 Compare June 8, 2020 06:51

nikic reviewed Jun 8, 2020

View reviewed changes

Make code more friendly

e72cab5

nikic approved these changes Jun 8, 2020

View reviewed changes

php-pulls closed this in 88355dd Jun 8, 2020

twose deleted the constify-2020 branch June 8, 2020 09:51

khs1994 mentioned this pull request Jun 30, 2020

unit with php8.0 build break by https://github.com/php/php-src/pull/5676 nginx/unit#440

Closed

Constify char* arguments of APIs #5676

Constify char* arguments of APIs #5676

Uh oh!

Conversation

twose commented Jun 7, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikic commented Jun 7, 2020

Uh oh!

twose commented Jun 7, 2020

Uh oh!

cmb69 commented Jun 7, 2020

Uh oh!

twose commented Jun 7, 2020

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

twose commented Jun 8, 2020

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!