IMAP: Fix UNKNOWN default values #6179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AppVeyor build fails:
|
Girgias
force-pushed
the
imap-unknow-values
branch
from
181d36c to
7e0ab1c
Compare
nikic
approved these changes
Sep 22, 2020
| @@ -2678,7 +2677,7 @@ PHP_FUNCTION(imap_sort) | |||
| mypgm->function = (short) pgm; | |||
| mypgm->next = NIL; | |||
|
|
|||
| slst = mail_sort(imap_le_struct->imap_stream, (argc == 6 ? ZSTR_VAL(charset) : NIL), spg, mypgm, (argc >= 4 ? flags : NIL)); | |||
| slst = mail_sort(imap_le_struct->imap_stream, (charset ? ZSTR_VAL(charset) : NIL), spg, mypgm, (argc >= 4 ? flags : NIL)); | |||
There was a problem hiding this comment.
Suggested change
| slst = mail_sort(imap_le_struct->imap_stream, (charset ? ZSTR_VAL(charset) : NIL), spg, mypgm, (argc >= 4 ? flags : NIL)); | |
| slst = mail_sort(imap_le_struct->imap_stream, (charset ? ZSTR_VAL(charset) : NIL), spg, mypgm, flags; |
to remove argc dependency. NIL is defined as 0.
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Oct 2, 2020
… function signature > The unused default_host argument of imap_headerinfo() has been removed. Refs: * https://github.com/php/php-src/blob/0a84fba0deb1c1b75770a436c4236dc56e6d0463/UPGRADING#L332 * php/php-src#6179 * php/php-src@5d7d5e2
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Oct 2, 2020
> The imap_header() function which is an alias of imap_headerinfo() has been removed. Refs: * https://github.com/php/php-src/blob/0a84fba0deb1c1b75770a436c4236dc56e6d0463/UPGRADING#L332 * php/php-src#6179 * php/php-src@5d7d5e2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A went and did a bit of refactoring at the same time to make this easier to implement.