IPv6 support for php-fpm (fixes: #55508) #631

globin · 2014-03-24T12:14:39Z

This removes hardcoded IPv4 code and adds support for IPv6

datibbaw · 2014-04-03T10:19:58Z

sapi/fpm/php-fpm.conf.in

@@ -55,7 +55,7 @@
 ; Default Value: 0
 ;emergency_restart_threshold = 0

-; Interval of time used by emergency_restart_interval to determine when 


Minor, but could you fix these silly space issues? :)

globin · 2014-04-03T11:24:28Z

fixed and rebased

acasademont · 2014-05-27T08:36:07Z

+1 please, php-fpm is the last component in our internal network that does not support ipv6, we would love to kill ipv4 internally :)

SjonHortensius · 2014-05-27T08:38:18Z

Yes I agree; we have the exact same problem. Everything runs over ipv6 but our firewalls need to make 1 exception because fpm cannot handle ipv6. The only alternative is running an instance of socat to convert ipv6 to ipv4....

jucrouzet · 2014-05-27T08:50:50Z

+1000 this would kill the last IPv4 dep

arjenschol · 2014-05-27T09:13:42Z

+1!
IPv6 support would be really really nice!

SanderVanLeeuwen · 2014-05-27T12:22:09Z

Yes please!

acasademont · 2014-07-03T22:15:50Z

Is somebody going to take a look at this before PHP 5.6?

Majkl578 · 2014-07-03T22:24:58Z

💯

What happens when one enters only port? Will it listen on both IPv4 and IPv6?

Majkl578 · 2014-07-06T02:24:05Z

Ping @Tyrael, what do you think? Possible for 5.6?

Tyrael · 2014-07-06T07:22:18Z

We are too deep into the release release (we already had an RC2, feature freeze since beta1) to have this in 5.6, but we I would like to see this in master. Sorry that we missed this, I will try to do a better job with keeping up with the pull requests, but if you see an rfc not getting the deserved attention, feel free to drop a reminder email to [email protected]

nikic · 2014-07-06T08:40:31Z

@Tyrael This looks like a minor, self-contained feature addition. Can't we add that in 5.6.1? Unless I misunderstand the impact, this could also go to 5.5.

Tyrael · 2014-07-06T08:57:26Z

@nikic it is a possibility for 5.6.1. for 5.5 we should ask @jpauli

Majkl578 · 2014-08-06T06:58:47Z

Bump.

arjenschol · 2014-08-06T07:58:29Z

We are too deep into the release release (we already had an RC2, feature freeze since beta1) to have this in 5.6, but we I would like to see this in master.

Surprisingly, this can be added in RC4: "Add SO_REUSEPORT + SO_BROADCAST support via socket stream context option" a51bf0c

No references to a pull request, bug report or whatsoever. An individual PHP develeoper with git access can do whatever they want. A pull request for IPv6 support which should have been added 5 years ago, with multiple votes and issues on bugs.php.net cannot be merged "because of feature freeze".

Strange...

acasademont · 2014-08-06T08:30:22Z

indeed this is pretty absurd...

jpauli · 2014-08-06T08:36:09Z

I'm all right to have this added to 5.5

jpauli · 2014-08-06T08:37:50Z

sapi/fpm/fpm/fpm_sockets.c

+	if (addr != NULL) {
+		addr_len = strlen(addr);
+		if (addr[0] == '[' && addr[addr_len - 1] == ']') {
+			addr[addr_len - 1] = '\0';


This looks like replacing ']' by \0 which seems strange to me

@jpauli if the user enters an ipv6 address with the [ip]:port format those [ and ] have to be removed. This line you pointed just deletes the ] in the last char and the next line addr++; deletes the [ in the first char

Yup I see now

Tyrael · 2014-08-06T09:52:24Z

@arjenschol Thanks for catching this, I've just sent an email to the author to revert
it, since we are in feature freeze since beta1.

fadenb · 2014-08-06T09:58:01Z

+1 lets get rid of legacy IP.

arjenschol · 2014-08-29T09:01:41Z

Now 5.6.0 is released, can this be pulled into the 5.6 branch for release in 5.6.1?

kaplanlior · 2014-08-29T09:23:27Z

From the thread above it seems you should have it into 5.5 and merge it
into 5.6...

On Fri, Aug 29, 2014 at 12:01 PM, Arjen [email protected] wrote:

Now 5.6.0 is released, can this be pulled into the 5.6 branch for release
in 5.6.1?

—
Reply to this email directly or view it on GitHub
#631 (comment).

acasademont · 2014-08-29T09:31:27Z

let me ping @Tyrael and @jpauli about this, hope we can finally make it!

Tyrael · 2014-09-01T11:59:30Z

I would be fine having this in 5.6.1, as it shouldn't have any impact for existing fpm deployments, but people can opt-in to listen on the v6 address with the new config option.
@jpauli what do you think about having it in 5.5?

jpauli · 2014-09-01T12:01:30Z

Yes sure, it can go to 5.5 as well

arjenschol · 2014-09-12T08:35:52Z

Meanwhile, some more features are being added to 5.6.1.. But not this patch.

With 5.6.1 now RC1, guess we have to wait at least another month..

acasademont · 2014-09-12T08:37:03Z

this must be a joke or something...

Tyrael · 2014-09-12T08:55:25Z

@jpauli so what are we waiting for merging this?

Majkl578 · 2014-09-13T01:28:45Z

This is sad. So much ignorance... 😟

Majkl578 · 2014-09-13T01:35:23Z

Also, noone yet answered my question:

What happens when one enters only port? Will it listen on both IPv4 and IPv6?

acasademont · 2014-09-13T10:46:58Z

@Majkl578 i can't guarantee that without testing it but looking at the code it should open connections for both ipv4 and ipv6 if you only set the port :)

Majkl578 · 2014-09-21T22:45:27Z

Bump again, ping @Tyrael + @jpauli. This is really getting awkward...

@acasademont: Thanks, that's how it should work, I was just curious whether the implementation is aware of that. :)

Majkl578 · 2014-10-03T00:26:36Z

Bump.

acasademont · 2014-10-03T08:48:39Z

Seems like it's time for PHP 5.6.2 merges :p

@Tyrael @jpauli please do not forget this one, thanks!

Tyrael · 2014-10-03T09:44:31Z

hi, I've merged the patch into 5.5 and upwards.
squashed the three commits into a single one, but kept you as the author.
thanks for the contribution, and sorry that it took this long to get it merged.

SjonHortensius · 2014-10-03T09:50:30Z

Wow, great.Thanks!

acasademont · 2014-10-03T13:34:04Z

thank you all! this is awesome news :D

acasademont · 2014-11-06T12:03:09Z

@jpauli @Tyrael in PHP 5.5.18 this PR was finally pulled off and added for 5.5.19 but the NEWS file states that this appeared on 5.5.18 which may lead to confusion. Could that line be added to the 5.5.19 changelog? Thanks!!

laruence · 2014-11-11T05:49:51Z

Hey @globin , I consistently see sapi/fpm/tests/003.phpt fails with:

Warning: fsockopen(): php_network_getaddresses: getaddrinfo failed: Address family for hostname not supported in /home/huixinchen/opensource/trunk/sapi/fpm/tests/003.php on line 24

leofeyer · 2014-11-14T13:38:00Z

This change (or another FPM related change in version 5.5.19 and 5.6.3) seems to break PHP-FPM when using the network stack. It can be reproduced e.g. on Ubuntu 14.04 by creating 5 different pools (port numbers 9001 to 9005) and then starting the PHP-FPM service. I would expect to have a listener on each of the five ports, instead only the first pool is actually loaded. The others fail to load (can e.g. be checked with netstat -tlpn | sort).

I had to downgrade to version 5.5.18/5.6.2 to fix the issue.

SjonHortensius · 2014-11-14T13:42:16Z

@leofeyer I have reported a similar bug for that @ https://bugs.php.net/bug.php?id=68420. I don't think posting bugs in the comments of PR is a good idea

leofeyer · 2014-11-14T14:11:16Z

@SjonHortensius Thanks, but this bug seems to handle a different issue, so I have created a separate one: https://bugs.php.net/bug.php?id=68423

See #631 (comment)

datibbaw reviewed Apr 3, 2014
View reviewed changes

globin added 3 commits April 3, 2014 13:23

add IPv6 support to php-fpm

e767189

check for addr==null and add ipv6 to conf

6057125

revert whitespace

12c3e72

globin changed the title ~~IPv6 support for php-fpm~~ IPv6 support for php-fpm (fixes: #55508) Apr 21, 2014

jpauli reviewed Aug 6, 2014
View reviewed changes

Tyrael closed this Oct 3, 2014

php-pulls pushed a commit that referenced this pull request Feb 11, 2015

Bug #55508 was fixed in 5.5.19 with 15ba757, not in 5.5.18

e6d8bad

See #631 (comment)

IPv6 support for php-fpm (fixes: #55508) #631

IPv6 support for php-fpm (fixes: #55508) #631

Uh oh!

Conversation

globin commented Mar 24, 2014

Uh oh!

datibbaw Apr 3, 2014

Choose a reason for hiding this comment

Uh oh!

globin commented Apr 3, 2014

Uh oh!

acasademont commented May 27, 2014

Uh oh!

SjonHortensius commented May 27, 2014

Uh oh!

jucrouzet commented May 27, 2014

Uh oh!

arjenschol commented May 27, 2014

Uh oh!

SanderVanLeeuwen commented May 27, 2014

Uh oh!

acasademont commented Jul 3, 2014

Uh oh!

Majkl578 commented Jul 3, 2014

Uh oh!

Majkl578 commented Jul 6, 2014

Uh oh!

Tyrael commented Jul 6, 2014

Uh oh!

nikic commented Jul 6, 2014

Uh oh!

Tyrael commented Jul 6, 2014

Uh oh!

Majkl578 commented Aug 6, 2014

Uh oh!

arjenschol commented Aug 6, 2014

Uh oh!

acasademont commented Aug 6, 2014

Uh oh!

jpauli commented Aug 6, 2014

Uh oh!

jpauli Aug 6, 2014

Choose a reason for hiding this comment

Uh oh!

acasademont Aug 6, 2014

Choose a reason for hiding this comment

Uh oh!

jpauli Aug 6, 2014

Choose a reason for hiding this comment

Uh oh!

Tyrael commented Aug 6, 2014

Uh oh!

fadenb commented Aug 6, 2014

Uh oh!

arjenschol commented Aug 29, 2014

Uh oh!

kaplanlior commented Aug 29, 2014

Uh oh!

acasademont commented Aug 29, 2014

Uh oh!

Tyrael commented Sep 1, 2014

Uh oh!

jpauli commented Sep 1, 2014

Uh oh!

arjenschol commented Sep 12, 2014

Uh oh!

acasademont commented Sep 12, 2014

Uh oh!

Tyrael commented Sep 12, 2014

Uh oh!

Majkl578 commented Sep 13, 2014

Uh oh!

Majkl578 commented Sep 13, 2014

Uh oh!

acasademont commented Sep 13, 2014

Uh oh!

Majkl578 commented Sep 21, 2014

Uh oh!

Majkl578 commented Oct 3, 2014

Uh oh!