Skip to content

Check if the macro AC_PROG_CC_C99 actually made the compiler accept C99 #6317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Danack
Copy link
Contributor

@Danack Danack commented Oct 10, 2020

Same idea as #6314 - check that the compiler support C99 so users get a decent error message, rather than a cryptic one.

This also need to be checked on a system that has a non-C99 compiler, and I don't have one to hand.

@Danack Danack marked this pull request as ready for review June 20, 2022 22:46
@Danack
Copy link
Contributor Author

Danack commented Jun 21, 2022

For reference, the original reason for this PR was https://bugs.php.net/bug.php?id=80211

@Girgias
Copy link
Member

Girgias commented Jan 25, 2023

Does this still make sense?

@php php deleted a comment from smokefire69 Jan 26, 2023
@Danack
Copy link
Contributor Author

Danack commented Jan 26, 2023

Meh.

The value for it is dropping over time. Not many people are complaining about PHP not being <C99. On the other hand it's cheap, and it gives a clear error message rather than leaving people wondering what is happening.

Assuming it doesn't break anything* it's probably worth committing. Comparing user time over the next ten years:

  • Time saved from people wondering wtf vs time taken up.

  • 100 people * 10 minutes * 60 seconds in a minute vs 0.00001 seconds per build * 10000 people who build PHP from source * 200 times a year * 10 years.

  • 60,000 seconds vs 200 seconds.

So....that seems worth it?

*ha.

@smokefire69

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants