Skip to content

Run arginfo/ZPP verification tests in strict mode as well #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate changed the base branch from master to PHP-8.0 October 22, 2020 10:50
@kocsismate
Copy link
Member Author

There's already two caught issues with dba_key_split() and highlight_string()

@nikic
Copy link
Member

nikic commented Oct 22, 2020

I fixed highlight_string, but dba_key_split is doing something seriously weird.

@nikic
Copy link
Member

nikic commented Oct 22, 2020

Behavior was introduced in 4d752bd. "Pass eof".

@nikic
Copy link
Member

nikic commented Oct 22, 2020

So, I guess this is intended to allow usage like dba_key_split(dba_nextkey($dba)) to just pass through the false return value...

@nikic
Copy link
Member

nikic commented Oct 22, 2020

It's weird but clearly intentional, so I've simply adjusted the stub in 97dd0eb.

@kocsismate
Copy link
Member Author

kocsismate commented Oct 22, 2020

@nikic Thanks for the fixes (and the merge), I can't work on this stuff right now :) But I can rebase at least.

@nikic
Copy link
Member

nikic commented Oct 22, 2020

I fixed another issue in bfe7a11, next up is a segfault in tidy.

@nikic
Copy link
Member

nikic commented Oct 22, 2020

Ugh, it's not even something subtle with uninitialized objects. This code is enough to crash:

<?php
$tidy = new tidy;
var_dump($tidy->getHtmlVer());

@nikic nikic force-pushed the arginfo-zzp-strict branch from 0c41118 to 3558de6 Compare October 22, 2020 14:09
@nikic
Copy link
Member

nikic commented Oct 22, 2020

Tidy issue fixed in d4bf079, now it at least passes locally.

@php-pulls php-pulls closed this in a8e92e3 Oct 22, 2020
@kocsismate kocsismate deleted the arginfo-zzp-strict branch October 22, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants