hrtime implementation update for Mac. #6609
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a more modern and simpler api available since Sierra (2016).
|
Thanks for keeping an eye on this part. Would it make sense to make a conditional compilation so an older OS version would still be covered? I've almost no idea about the Mac versions and usage stats, is losing some audience on older OS versions negligible? Thansk. |
|
I considered that but the reason I put it in master to target next major PHP release to give it more time for fairness. I stumbled across these stats seems even Sierra is alreay pretty low today. https://gs.statcounter.com/macos-version-market-share/desktop/worldwide/2020 |
|
Sounds fair enough for me. Thanks fro the additional check. |
weltling
approved these changes
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a more modern and simpler api available since Sierra (2016).