Fix bug #80600 DOMChildNode::remove does not work on DOMCharacterData. #6660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @cmb69 |
nikic
approved these changes
Feb 2, 2021
cmb69
approved these changes
Feb 2, 2021
beberlei
force-pushed
the
bug80600-domchildnode-remove
branch
from
a3d8030 to
99b9ef5
Compare
|
@beberlei The test you added fails for me on master on my Mac (2019 MBP): I saw that it passes in CI, so I'm not sure what the problem is. UPDATE: it turned out that I accidentally ran run_tests.php via PHP 8.0.. Sorry for the noise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=80600
Problem was an erroreous check if
childwas valid to have child nodes, but the check must be made for the parents. Also cleans up code duplication betweenPHP_METHOD(DOMCharacterData, remove)anddom_child_node_remove.