Skip to content

Update CIs links on release-process docs #6674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update CIs links on release-process docs #6674

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link
Contributor

Couple of updates:

  • Travis CI is now on .com, no longer on .org
  • We also use AppVeyor and Azure, so let's list them
  • "CI are green" does not fit colorblinds, let's avoid it

Couple of updates:

- Travis CI is now on .com, no longer on .org
- We also use AppVeyor and Azure, so let's list them
- "CI are green" does not fit colorblinds, let's avoid it
@carusogabriel carusogabriel added the Category: Documentation This is for documentation inside php-src, not on php.net label Feb 8, 2021
@@ -8,9 +8,11 @@
2. Package two days before a release. So if the release is to be on Thursday,
package on Tuesday. Think about timezones as well.

3. Ensure that the tests on Travis CI are green.
3. Ensure that the tests on CIs are okay. See:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Ensure that the tests on CIs are okay. See:
3. Ensure that the tests on CIs are working. See:

or

Suggested change
3. Ensure that the tests on CIs are okay. See:
3. Ensure that the tests on CIs are succeeding. See:

are also options here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "okay" is fine.

@Girgias
Copy link
Member

Girgias commented Feb 9, 2021

You might want to specify that Travis CI is limited to PHP 7.3 (which is a security release).
As with the .org removal we dropped it for 8.0/master and I'm pretty sure for 7.4 too.

@carusogabriel
Copy link
Contributor Author

@Girgias Once this one is accepted, I'll go downstream and update the ones needed. RMs know where to look, but I think it's important to update the master's one for future Release Managers :)

@cmb69
Copy link
Member

cmb69 commented Mar 10, 2021

I think PHP-7.3 should be left alone with this; it may be okay for PHP-7.4, but I'm not sure whether release managers actually look at that; I use the one in master for a long time.

Anyhow, just drop the mention of Travis; these builds are no longer working for several weeks now, and it's somewhat unlikely to find somebody to sponsor travis.com, besides that Azure Pipelines are working well for us.

@carusogabriel
Copy link
Contributor Author

Fixed via #6829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Documentation This is for documentation inside php-src, not on php.net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants