Skip to content

Increase .idea on gitignore and increase early return on php display error #6760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Increase .idea on gitignore and increase early return on php display error #6760

wants to merge 2 commits into from

Conversation

Calison25
Copy link
Contributor

Remove else if for make method more readable, and early return for make method more faster.

Girgias
Girgias requested changes Mar 13, 2021
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the addition to gitignore, IDE files should be added to your global gitignore config as stated in the beginning of the file.

.gitignore Outdated
Comment on lines 289 to 290

.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.idea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll remove.

@php-pulls php-pulls closed this in 021c988 Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Calison25 @Girgias