🐛 Fixed Bug #80908 PDO::lastInsertId() return wrong.

[AtlanticF]

Fixed Bug #80908

MySQL api function last_insert_id() always return unsigned interger,
but in ext.pdo_mysql we use int64 to receive the uint64 return value.
When MySQL table auto_increment id bigger than the maximum value of
int64, ext.pdo_mysql will treat as int64.

[Girgias]

I'm not sure the approach of mimicking the signed version is totally correct, as I could imagine some overflow into negative numbers for very large 64 bit integers, can you add a test?

[Girgias]

This could also handle all numbers which are a single digit

[Girgias]

Suggested change

	register char *p;
	char *p;

From my understanding this is pretty meaningless.

[Girgias]

Suggested change

	while ((uint64_t)i64 > (uint64_t)ZEND_LONG_MAX) {
	while (i64 > (uint64_t)ZEND_LONG_MAX) {

i64 is already an uint64_t

[AtlanticF]

I'm not sure the approach of mimicking the signed version is totally correct, as I could imagine some overflow into negative numbers for very large 64 bit integers, can you add a test?

@Girgias Thanks for your code review. I will provider a test. The test steps:

1. Create a test table

// Let the table auto_increment id start from `10376293541461622799`. It's bigger than int64.
create table foo (`id` bigint(20) unsigned AUTO_INCREMENT, `name` varchar(5), primary key (`id`)) ENGINE = InnoDB AUTO_INCREMENT=10376293541461622799;

2. Run the test.php

<?php
$dbh = new PDO('mysql:host=docker.for.mac.localhost:33060;dbname=test', 'root', 'secret');
$dbh->exec("insert into foo (`name`) values ('bar')");
echo $dbh->lastInsertId() . PHP_EOL;
// If we not fix the bug, this test will return a string '-8070450532247928817'

In fact, MySQL Client C API function last_insert_id() is always return an unsigned int64

[nikic]

I don't think PDO should be responsible for implementing this functionality, so I've added some generic Zend APIs in 65a5c18.

This PR should now just be a matter of switching from zend_i64_to_str to zend_u64_to_str.