Use typed properties in ext/zip #6881
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From a quick glance, it looks like zip is not enforcing these to be readonly? Writes are allowed, but just go into the void. |
I thought that since the write handler is missing, they will be read-only. But you must be right, they are most probably "writable". I'll fix this and also add a test. |
kocsismate
force-pushed
the
typed-property-zip
branch
from
43b9ef6 to
c176ade
Compare
kocsismate
force-pushed
the
typed-property-zip
branch
from
c176ade to
48203c4
Compare
kocsismate
commented
Apr 20, 2021
nikic
reviewed
Apr 26, 2021
nikic
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.