Fix #50713: openssl_pkcs7_verify() may ignore untrusted CAs #6927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`openssl_pkcs7_verify()` works fine with untrusted CAs, as long as one doesn't specify a `$signers_certificates_filename` in which case the verification fails, because we're not passing along the untrusted CAs to `PKCS7_get0_signers()`.
|
The change looks correct to me but we surely need a test for this. It would be really good to cover it as similar functionality is in CMS where it's not cover as well. Although it doesn't have this issue. I have been playing with integrating CertificateGenerator into it a bit but need more time to make it nicely work. I will let you know once I have got something working. |
|
Finally got to this and managed to create a proper test. I opened new PR: #12499 so this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openssl_pkcs7_verify()works fine with untrusted CAs, as long as onedoesn't specify a
$signers_certificates_filenamein which case theverification fails, because we're not passing along the untrusted CAs
to
PKCS7_get0_signers().I would need some help regarding writing a regression test.