Use sapi/cli/php to run tests for faster failure #6931
Conversation
|
The build is installed, doesn't it already use that binary ? |
|
Oh right. Actual motivation here is to fail hard if the build step fails. We always run tests even if previous steps failed (so that if one test job fails, others still run), but we don't want to run tests if the build itself fails. If we do, the tests end up hanging and will time out. So this was my idea for an easy way to bail if the build failed. |
|
That seems like it will work ... maybe break it and see how it behaves ? Fail quite quickly is what I expect ... not sure what it might do to test data. |
|
Seems to work file. Test count for successful build is same as before (128204) and the test job fails in 1s if the build failed. Need to adjust macos tests as well though, as these are implemented separately... |
|
That seems okay .... I think it might be possible to use a combination of dependsOn and condition to make it even cleaner ... but playing with this was a headache, and we might have already tried during initial setup. |
I also looked at that, but from what I understood, dependsOn is a feature for jobs and stages, while we're only working with steps here. We'd have to convert some of the steps into stages, and that seems like too much hassle ^^ |
|
Yeah agree, probably too much hassle ... and I got this feeling we have already tried ... |
nikic
changed the title
No description provided.